-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gitlab): support GitLab CI/CD component references #26660
Conversation
f357a73
to
7458246
Compare
0d922d5
to
36fbbc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would prefer if you could implement this in gitlabci
as we plan to merge gitlabci-include
into it eventually.
It should be reasonable possible to use a schema for this sub part.
I tried to keep it very similar to the existing logic. Would it be OK to keep it here to get the feature out and afterwards I start a PR to merge the two managers (will take a bit I guess)? |
Please move it now, else we will have to write migrations to move people over. |
7e4ba41
to
457c124
Compare
I have rebased this. Ready for another round of 👀 |
{ err, packageFile }, | ||
'Error extracting GitLab CI dependencies', | ||
); | ||
if (err.stack?.startsWith('YAMLException:')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I don't really see a benefit for this conditional logging. only message is different
@rarkins WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not too ambitious about it. I have copied it from the existing code in the gitlabci-include
manager.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But agreed, the different message does not bring much benefit, unless someone explicitly wants to match for it in their logging.
8f09463
to
b3417de
Compare
b3417de
to
3cbce5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last change 🤗
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
🎉 This PR is included in version 37.148.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
…26660) Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Changes
This PR adds support for bumping references to GitLab CI/CD components.
Context
Resolves #23431
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
- https://gitlab.com/fgreinacher/renovate-cicd-components-3/-/merge_requests
⚒️ with ❤️ by @siemens