Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use toml-eslint-parser instead of @iarna/toml #25594

Merged
merged 9 commits into from
Nov 6, 2023
Merged

fix: Use toml-eslint-parser instead of @iarna/toml #25594

merged 9 commits into from
Nov 6, 2023

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Nov 5, 2023 •
edited
Loading

Changes

  • Remove dependency on @iarna/toml which lacks support for the recent TOML spec
  • Use toml-eslint-parser instead

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

zharinov
zharinov commented Nov 5, 2023
View reviewed changes
lib/util/toml.ts Outdated Show resolved Hide resolved
@zharinov zharinov requested review from viceice and rarkins November 5, 2023 23:10
@zharinov
Copy link
Collaborator Author

zharinov commented Nov 5, 2023

Examples: https://github.com/renovate-testing/test-25594-toml-v1/pulls

viceice
viceice reviewed Nov 6, 2023
View reviewed changes
lib/util/toml.ts Outdated Show resolved Hide resolved
zharinov and others added 3 commits November 6, 2023 04:08
@zharinov @viceice
Update lib/util/toml.ts
d40e509 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@zharinov
Merge branch 'main' into fix/toml-v1-spec
4730d7f
@zharinov
Fix
fe0d495
@zharinov zharinov requested a review from viceice November 6, 2023 07:15
@rarkins rarkins added this pull request to the merge queue Nov 6, 2023
Merged via the queue into renovatebot:main with commit d82ff36 Nov 6, 2023
32 checks passed
@rarkins rarkins deleted the fix/toml-v1-spec branch November 6, 2023 15:54
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.48.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@viceice viceice mentioned this pull request Nov 8, 2023
Open
jon4hz pushed a commit to jon4hz/renovate that referenced this pull request Nov 9, 2023
@zharinov @viceice @jon4hz
fix: Use toml-eslint-parser instead of @iarna/toml (renovatebot#2…
0af4b7e 
…5594)

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Renovate does not support latest TOML v1.0.0 spec.
4 participants
@zharinov @renovate-release @viceice @rarkins