fix(regex): don’t escape forward slash in fileMatch #19314

rarkins · 2022-12-08T12:25:42Z

Changes

Removes unnecessary forward slash escaping.

Context

Closes #19312

Documentation (please check one with an [x])

I have updated the documentation, or
No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

Code inspection only, or
Newly added/modified unit tests, or
No unit tests but ran on a real repository, or
Both unit tests + ran on a real repository

Closes #19312

viceice

we should search for additional \\/ to replace

lib/modules/manager/flux/common.ts

lib/modules/manager/fvm/index.ts

lib/modules/manager/gradle/index.ts

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

Churro · 2022-12-08T14:44:27Z

This branch doesn't yet see two more patterns that PR #19182 introduced in lib/modules/manager/gradle/index.ts just today. Probably also worth considering in this PR👍

rarkins · 2022-12-08T15:28:04Z

Now replaced all, but I'd like to be paranoid and have multiple eyes on this.

viceice

otherwise LGTM

lib/config/options/index.ts

rarkins · 2022-12-09T11:52:29Z

@JamieMagee another set of eyes please :)

JamieMagee

This looks okay, but we might need to document the trimming of / in regex patterns. The standard¹ says that the first character of a regex is the delimiter, but the delimiter can be any character. / is just a convention, but I've seen #, @, etc. used, which makes it easier when / is a part of the pattern you're trying to match.

https://en.wikipedia.org/wiki/Regular_expression#Delimiters ↩

rarkins · 2022-12-09T18:03:22Z

I think we've mentioned that / ... / or !/ ... / are our conventions whenever a field supports it, but we can double check

# Conflicts: # lib/config/presets/internal/monorepo.ts # lib/modules/manager/woodpecker/index.ts

rarkins · 2023-01-23T10:09:06Z

Non-breaking but will release it as part of v35 just in case

Changes `rangeStrategy` default value from `'replace'` to `'auto'`. Changes `auto` behavior so that `update-lockfile` is preferred if the manager supports the `updateLockedDependency()` function. Closes #19800 BREAKING CHANGE: Renovate will now default to updating locked dependency versions. To revert to previous behavior, configure rangeStrategy=replace.

…9958) Sets new defaults: - `prConcurrentLimit`: 10 (instead of 0) - `prHourlyLimit`: 2 (instead of 0) Closes #19800 BREAKING CHANGE: Renovate now defaults to applying hourly and concurrent PR limits. To revert to unlimited, configure them back to `0`.

Set default GOPROXY value to match `go`'s own default. Closes #20040 BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.

lib/modules/manager/woodpecker/index.ts

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

JamieMagee · 2023-01-30T04:48:44Z

There are some docs updates, but they won't block code changes:

renovate/lib/modules/manager/regex/readme.md

Lines 183 to 184 in b376b8e

    
                   "['\"]?(?<depName>/pipeline-fragments\\/fragment-version-check)['\"]?\\s*ref:\\s['\"]?(?<currentValue>[\\d-]*)['\"]?", 
        
                   "['\"]?(?<depName>pipeline-solutions\\/gitlab\\/fragments\\/fragment-version-check)['\"]?\\s*ref:\\s['\"]?(?<currentValue>[\\d-]*)['\"]?"

renovate/docs/usage/configuration-options.md

Line 1731 in b376b8e

"matchBaseBranches": ["/^release\\/.*/"],
renovate/docs/usage/configuration-options.md

Line 2700 in b376b8e

"image:\\s+(?<depName>my\\.old\\.registry\\/aRepository\\/andImage):(?<currentValue>[^\\s]+)"

fix(regex): don’t escape forward slash in fileMatch

752bf0a

Closes #19312

rarkins requested review from viceice and JamieMagee December 8, 2022 12:25

viceice reviewed Dec 8, 2022

View reviewed changes

lib/modules/manager/flux/common.ts Outdated Show resolved Hide resolved

lib/modules/manager/fvm/index.ts Outdated Show resolved Hide resolved

lib/modules/manager/gradle/index.ts Outdated Show resolved Hide resolved

Apply suggestions from code review

f0f1ee5

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

rarkins added 2 commits December 8, 2022 16:26

replace all

2996529

Merge branch 'main' into fix/19312-file-match-forward-slash

267ded7

viceice reviewed Dec 9, 2022

View reviewed changes

lib/config/options/index.ts Show resolved Hide resolved

viceice previously approved these changes Dec 9, 2022

View reviewed changes

JamieMagee previously approved these changes Dec 9, 2022

View reviewed changes

Merge branch 'main' into fix/19312-file-match-forward-slash

fe060df

# Conflicts: # lib/config/presets/internal/monorepo.ts # lib/modules/manager/woodpecker/index.ts

rarkins dismissed stale reviews from JamieMagee and viceice via fe060df January 23, 2023 10:06

rarkins changed the base branch from main to v35 January 23, 2023 10:08

RahulGautamSingh and others added 5 commits January 29, 2023 07:12

feat(config)!: add new option constraintsFiltering (#19992)

3370c00

feat(cache): default cacheHardTtlMinutes to 24 hours (#20079)

757b2c7

feat(go)!: default GOPROXY (#20081)

0994718

Set default GOPROXY value to match `go`'s own default. Closes #20040 BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.

rarkins force-pushed the v35 branch from 865316a to 0994718 Compare January 29, 2023 06:12

Merge branch 'v35' into fix/19312-file-match-forward-slash

38da1db

rarkins requested review from viceice, secustor and JamieMagee January 29, 2023 06:23

viceice reviewed Jan 29, 2023

View reviewed changes

lib/modules/manager/woodpecker/index.ts Outdated Show resolved Hide resolved

Update lib/modules/manager/woodpecker/index.ts

80aac1e

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

rarkins requested a review from viceice January 29, 2023 15:59

viceice approved these changes Jan 29, 2023

View reviewed changes

JamieMagee added the v35 label Jan 30, 2023

JamieMagee approved these changes Jan 30, 2023

View reviewed changes

docs

816b482

rarkins force-pushed the v35 branch from 0994718 to 4b8dca0 Compare January 30, 2023 05:52

Merge branch 'v35' into fix/19312-file-match-forward-slash

5292b59

rarkins requested review from JamieMagee and viceice January 30, 2023 05:53

JamieMagee approved these changes Jan 30, 2023

View reviewed changes

rarkins merged commit 1a88ee0 into v35 Jan 30, 2023

rarkins deleted the fix/19312-file-match-forward-slash branch January 30, 2023 06:37

rarkins added a commit that referenced this pull request Jan 31, 2023

fix(regex): don’t escape forward slash in fileMatch (#19314)

e7a5eed

rarkins added a commit that referenced this pull request Feb 4, 2023

fix(regex): don’t escape forward slash in fileMatch (#19314)

fdeba67

rarkins added a commit that referenced this pull request Feb 10, 2023

fix(regex): don’t escape forward slash in fileMatch (#19314)

bb827ae

rarkins added a commit that referenced this pull request Feb 17, 2023

fix(regex): don’t escape forward slash in fileMatch (#19314)

1283705

rarkins added a commit that referenced this pull request Feb 20, 2023

fix(regex): don’t escape forward slash in fileMatch (#19314)

8846efe

rarkins added a commit that referenced this pull request Feb 23, 2023

fix(regex): don’t escape forward slash in fileMatch (#19314)

885ce79

rarkins added a commit that referenced this pull request Feb 25, 2023

fix(regex): don’t escape forward slash in fileMatch (#19314)

3f07829

rarkins added a commit that referenced this pull request Feb 27, 2023

fix(regex): don’t escape forward slash in fileMatch (#19314)

333f5c2

github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(regex): don’t escape forward slash in fileMatch #19314

fix(regex): don’t escape forward slash in fileMatch #19314

rarkins commented Dec 8, 2022 •

edited

Loading

viceice left a comment

Churro commented Dec 8, 2022

rarkins commented Dec 8, 2022

viceice left a comment

rarkins commented Dec 9, 2022

JamieMagee left a comment

rarkins commented Dec 9, 2022

rarkins commented Jan 23, 2023

JamieMagee commented Jan 30, 2023

fix(regex): don’t escape forward slash in fileMatch #19314

fix(regex): don’t escape forward slash in fileMatch #19314

Conversation

rarkins commented Dec 8, 2022 • edited Loading

Changes

Context

Documentation (please check one with an [x])

How I've tested my work (please select one)

viceice left a comment

Choose a reason for hiding this comment

Churro commented Dec 8, 2022

rarkins commented Dec 8, 2022

viceice left a comment

Choose a reason for hiding this comment

rarkins commented Dec 9, 2022

JamieMagee left a comment

Choose a reason for hiding this comment

Footnotes

rarkins commented Dec 9, 2022

rarkins commented Jan 23, 2023

JamieMagee commented Jan 30, 2023

rarkins commented Dec 8, 2022 •

edited

Loading