-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager/asdf): add support for .tools-versions as used by asdf #17166
Conversation
e3003e9
to
394b131
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thinking if we should name this manager tools-versions
instead, as maybe other tools are using the same file in future. so we are more generic here.
@rarkins WDYT?
I'd like to extend this to support other tooling that asdf can manage that is also supported by renovate. However I only use it for node and yarn so I would be looking for guidance on how to add support for the following A few may make it (this is a just a first glance at potential candidate) and then leave additional support for those that need it to implement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think we should rename this manager to tools-versions
, as the processed filename is pretty generic, and maybe other tools will use the same file.
@rarkins @JamieMagee WDYT?
but would they use it in the same way? If two tools used the same file but in a different manner then a single manager would struggle to maintain the file for all uses. I believe (because I have never tried to) we can control the managers being used from the renovate.config so then the repo owner can choose the correct manager for the file? |
It seems unlikely that another tool would adopt an incompatibility |
What do we need to do next? |
🎉 This PR is included in version 32.199.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
@sawilde I'm just seeing the content of this PR now; it seems the asdf filename is |
Thanks for the spot, what a stupid typo by me - too busy concentrating on parsing the file and missed the little, yet important thing. |
Context
Basic support for managing nodejs versions as seen in
.tools-versions
files that is used by asdfDocumentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: