feat(manager/tool-versions): support .tool-versions #14092
Conversation
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
|
Hi @viceice could you please advice why this linter error could appear? I'm a bit confused how it was possible.. |
|
You need to run @zharinov can you give some suggestions for the strict null errors? |
|
Suggested edit: diff --git a/tsconfig.strict.json b/tsconfig.strict.json
index e5591d0e6..857dae15f 100644
--- a/tsconfig.strict.json
+++ b/tsconfig.strict.json
@@ -337,6 +337,8 @@
"lib/manager/terragrunt/extract.ts",
"lib/manager/terragrunt/index.ts",
"lib/manager/terragrunt/modules.ts",
+ "lib/manager/tool-versions/extract.ts",
+ "lib/manager/tool-versions/index.ts",
"lib/manager/travis/extract.ts",
"lib/manager/travis/index.ts",
"lib/platform/api.ts", |
|
@olegkrivtsov Sorry for confusion, we're transitioning our codebase to strict null checks |
|
Shouldn't we make this PR strict compatible now? Or are there too may transitive errors? |
lib/manager/tool-versions/__fixtures__/.tool-versions-with-ignore-comments
Outdated
Show resolved
Hide resolved
…olegkrivtsov/renovate into feat/4051-support-tool-versions
| currentDigest: '10.15.0', | ||
| currentRawValue: 'ref:10.15.0', |
There was a problem hiding this comment.
I'm not sure if this is what we like to have. 🤔
There was a problem hiding this comment.
Hi @viceice could you please tell me what's incorrect here and what you'd like to see instead? I'm a bit confused, since I thought 'ref' is typically a digest?
There was a problem hiding this comment.
Also, would currentRawValue be useful here or I should remove it?
There was a problem hiding this comment.
I think that if it's a version then this should be currentValue and not currentDigest, and we should use semver versioning
There was a problem hiding this comment.
@rarkins I currently use semver-coerced, because in their doc examples versions sometimes look like semver-coerced: v1.0.3-a. This version won't be a valid semver, which always should look as 1.0.3.
| { | ||
| currentValue: '3.2.5', | ||
| currentVersion: '3.2.5', | ||
| datasource: 'ruby-version', |
There was a problem hiding this comment.
We need to check how they build/compile this version. If they build it directly from repo source, then it should also be github-tags
There was a problem hiding this comment.
@rarkins as their docs state, they build the version from source by compiling. So I will use github-tags in that case as you suggest.
| currentValue: '10.15.0', | ||
| currentVersion: '10.15.0', | ||
| datasource: 'github-tags', | ||
| depName: 'nodejs', |
There was a problem hiding this comment.
We should add node versioning too if the current value is a valid version
| currentDigest: '10.15.0', | ||
| currentRawValue: 'ref:10.15.0', |
There was a problem hiding this comment.
I think that if it's a version then this should be currentValue and not currentDigest, and we should use semver versioning
|
Converted to draft as @olegkrivtsov is not currently able to work on this for some time |
Changes:
Upgrade versions in .tool-versions #4051
Context:
Closes #4051
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: