Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: prepare esm helper #13250

Merged
merged 3 commits into from
Dec 22, 2021
Merged

refactor: prepare esm helper #13250

merged 3 commits into from
Dec 22, 2021

Conversation

viceice
Copy link
Member

@viceice viceice commented Dec 22, 2021

Changes:

  • add expose.cjs file to (dynamic) import package.json and re2;
  • I don't like to make the regEx async to use dynamic typescript import.
  • We can't import json files in esm by default yet, needs node --experimental-json-modules

Context:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested a review from rarkins December 22, 2021 15:14
lib/expose.cjs Show resolved Hide resolved
lib/expose.cjs Show resolved Hide resolved
@viceice viceice requested a review from JamieMagee December 22, 2021 15:20
lib/globals.d.ts Outdated Show resolved Hide resolved
lib/types/base.ts Outdated Show resolved Hide resolved
@viceice viceice requested a review from rarkins December 22, 2021 15:27
@viceice viceice merged commit 5e0e9ac into main Dec 22, 2021
@viceice viceice deleted the feat/refactor-4-esm branch December 22, 2021 16:01
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 31.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

zanitete pushed a commit to nagra-insight/renovate that referenced this pull request Jan 4, 2022
* refactor: prepare esm helper

* chore: fix type name
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants