refactor: Split exec function to smaller blocks #11093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Aug 5, 2021
zharinov
force-pushed
the
refactor/exec-internals
branch
from
025f9f7 to
9c03a98
Compare
viceice
approved these changes
Aug 12, 2021
|
🎉 This PR is included in version 25.72.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Split large
exec()function into smaller functions that hopefully are more understandable.Context:
We're about to implement cache volumes that would complicate it even more. So, I've refactored it here.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: