Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(maven): Remove file protocol support from datasource #10191

Merged
merged 10 commits into from
May 28, 2021

Conversation

zharinov
Copy link
Collaborator

Changes:

Ignore registry urls like file:///tmp/foo/bar

Context:

Closes #10037

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs update for clojure tests 🙃

@HonkingGoose
Copy link
Collaborator

@zharinov Seems it needs Jest snapshot updates?

@HonkingGoose HonkingGoose requested a review from viceice May 28, 2021 09:42
zharinov and others added 2 commits May 28, 2021 13:48
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@rarkins rarkins requested a review from viceice May 28, 2021 10:09
@viceice viceice merged commit d004ca5 into renovatebot:main May 28, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maven datasource should use fs wrapper
4 participants