Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Node.js 11 #3445

Closed
rarkins opened this issue Mar 26, 2019 · 1 comment · Fixed by #3549
Closed

Support Node.js 11 #3445

rarkins opened this issue Mar 26, 2019 · 1 comment · Fixed by #3549

Comments

@rarkins
Copy link
Collaborator

rarkins commented Mar 26, 2019

Tests fail if using Node.js 11.x.

Using Node.js 10.x seems to have worked. However, I noticed that all the errors with Node.js 11.x are due to the order of the objects being different. If you look at the error messages I posted above, all the error messages are still there but in the wrong order.

Originally posted by @JamieMagee in #3396 (comment)
@rarkins rarkins added ready and removed ready labels Mar 31, 2019
@JamieMagee JamieMagee mentioned this issue Apr 16, 2019
Merged
rarkins pushed a commit that referenced this issue Apr 16, 2019
@JamieMagee @rarkins
fix: nodejs 11 support (#3549)
05a46dd 
Due to an update in the v8 runtime, Node.js `Array.prototype.sort()` is now stable (See [here](nodejs/node#22754 (comment))).

These changes allow for tests to pass on both Node.js 10 and 11.

Fixes #3445
@renovate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 16.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: nodejs 11 support
2 participants
@rarkins @renovate-bot