Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preset): fix electron-forge monorepo url #25827

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

BreakBB
Copy link
Contributor

@BreakBB BreakBB commented Nov 16, 2023

Changes

Updated the URL for the electron-forge monorepo.

Context

Related to #25826

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep both URLs just in case there's some crossover time between both

@viceice viceice requested a review from rarkins November 16, 2023 08:47
viceice
viceice previously approved these changes Nov 16, 2023
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs prettier fix

@rarkins rarkins added this pull request to the merge queue Nov 16, 2023
Merged via the queue into renovatebot:main with commit 09075d7 Nov 16, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.60.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@BreakBB BreakBB deleted the fix-electron-forge-preset branch November 16, 2023 13:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants