electron-forge monorepo preset not working

[BreakBB]

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us what version of Renovate you run.

37.59.8@sha256:1179e913e97f5221922b680650f2d31eddd9645609c84406d839599e1ecfc0c1

If you're self-hosting Renovate, select which platform you are using.

GitLab self-hosted

Was this something which used to work for you, and then stopped?

I never saw this working

Wanted end result.

I want all updates for electron-forge to be grouped together in a single PR.

What you tried so far.

I added the preset from the docs: https://docs.renovatebot.com/presets-group/#groupelectron-forgemonorepo

I noticed this URL is not the correct one, even though there is a redirect
https://github.com/renovatebot/renovate/blob/1bbb7ebe5c7ba6420e0400b550a42bfed6c7883f/lib/config/presets/internal/monorepo.ts#L261C22-L261C73

Instead it now is https://github.com/electron/forge.

Relevant debug logs

Logs

DEBUG: 7 flattened updates found: @electron-forge/cli, @electron-forge/maker-deb, @electron-forge/maker-rpm, @electron-forge/maker-squirrel, @electron-forge/maker-zip, @electron-forge/plugin-auto-unpack-natives, electron
DEBUG: Found sourceUrl with multiple branches that should probably be combined into a group
       "sourceUrl": "https://github.com/electron/forge",
       "newVersion": "7.0.0",
       "branches": {
         "REN-electron-forge-cli-7.x": "@electron-forge/cli",
         "REN-electron-forge-maker-deb-7.x": "@electron-forge/maker-deb",
         "REN-electron-forge-maker-rpm-7.x": "@electron-forge/maker-rpm",
         "REN-electron-forge-maker-squirrel-7.x": "@electron-forge/maker-squirrel",
         "REN-electron-forge-maker-zip-7.x": "@electron-forge/maker-zip",
         "REN-electron-forge-plugin-auto-unpack-natives-7.x": "@electron-forge/plugin-auto-unpack-natives"
       }

[rarkins]

PRs welcome

[BreakBB]

Okay, so that URL mismatch is actually the reason, why renovate does not group these dependencies?

PRs welcome

I'll take care of it 👍🏻

[rarkins]

Groupings like that are based on source url and if it changes then we need to add the new url

[HonkingGoose]

Fixed by PR:

• fix(preset): fix electron-forge monorepo url #25827

[BreakBB]

Looks like, this is not fixed. Even with renovate 37.61.3@sha256:94e0f70237a5a575088546974d3230096fcdd194557da329858809ee90fab1fb I still get

DEBUG: Found sourceUrl with multiple branches that should probably be combined into a group 
       "sourceUrl": "https://github.com/electron/forge",
       "newVersion": "7.1.0",
       "branches": {
         "REN-electron-forge-cli-7.x": "@electron-forge/cli",
         "REN-electron-forge-maker-deb-7.x": "@electron-forge/maker-deb",
         "REN-electron-forge-maker-rpm-7.x": "@electron-forge/maker-rpm",
         "REN-electron-forge-maker-squirrel-7.x": "@electron-forge/maker-squirrel",
         "REN-electron-forge-maker-zip-7.x": "@electron-forge/maker-zip",
         "REN-electron-forge-plugin-auto-unpack-natives-7.x": "@electron-forge/plugin-auto-unpack-natives"
       }

ofc with the monorepo preset from the docs

        {
            "extends": "monorepo:electron-forge",
            "groupName": "electron-forge monorepo",
            "matchUpdateTypes": [
                "digest",
                "patch",
                "minor",
                "major"
            ]
        },

[BreakBB]

Nevermind, looks like the correct version wasn't pulled on my side after the release of the fix. Working as expected now.

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction.

We may close the discussion if you, or someone else, haven't created a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team