test(lib/util): Refactor snapshot tests (#13289)

renovatebot · Dec 27, 2021 · 15a1208 · 15a1208
1 parent 6a26656
commit 15a1208
Show file tree

Hide file tree

Showing 15 changed files with 155 additions and 369 deletions.
diff --git a/lib/util/__snapshots__/host-rules.spec.ts.snap b/lib/util/__snapshots__/host-rules.spec.ts.snap
diff --git a/lib/util/__snapshots__/markdown.spec.ts.snap b/lib/util/__snapshots__/markdown.spec.ts.snap
diff --git a/lib/util/__snapshots__/package-rules.spec.ts.snap b/lib/util/__snapshots__/package-rules.spec.ts.snap
diff --git a/lib/util/exec/__snapshots__/index.spec.ts.snap b/lib/util/exec/__snapshots__/index.spec.ts.snap
diff --git a/lib/util/exec/index.spec.ts b/lib/util/exec/index.spec.ts
@@ -748,8 +748,21 @@ describe('util/exec/index', () => {
     await exec(inCmd, { docker });
     await exec(inCmd, { docker });
 
-    // FIXME: explicit assert condition
-    expect(actualCmd).toMatchSnapshot();
+    expect(actualCmd).toEqual([
+      `echo hello`,
+      `echo hello`,
+      `docker pull renovate/image`,
+      `docker ps --filter name=renovate_image -aq`,
+      `docker run --rm --name=renovate_image --label=renovate_child renovate/image bash -l -c "echo hello"`,
+      `docker ps --filter name=renovate_image -aq`,
+      `docker run --rm --name=renovate_image --label=renovate_child renovate/image bash -l -c "echo hello"`,
+      `echo hello`,
+      `echo hello`,
+      `docker ps --filter name=renovate_image -aq`,
+      `docker run --rm --name=renovate_image --label=renovate_child renovate/image bash -l -c "echo hello"`,
+      `docker ps --filter name=renovate_image -aq`,
+      `docker run --rm --name=renovate_image --label=renovate_child renovate/image bash -l -c "echo hello"`,
+    ]);
   });
   it('Supports binarySource=install', async () => {
     process.env = processEnv;

diff --git a/lib/util/git/__snapshots__/index.spec.ts.snap b/lib/util/git/__snapshots__/index.spec.ts.snap
diff --git a/lib/util/git/author.spec.ts b/lib/util/git/author.spec.ts
@@ -9,31 +9,23 @@ describe('util/git/author', () => {
       expect(parseGitAuthor('renovate@whitesourcesoftware.com')).not.toBeNull();
     });
     it('parses bot email', () => {
-      // FIXME: explicit assert condition
-      expect(parseGitAuthor('renovate[bot]@users.noreply.github.com'))
-        .toMatchInlineSnapshot(`
-        Object {
-          "address": "renovate[bot]@users.noreply.github.com",
-          "name": "renovate[bot]",
-        }
-      `);
+      expect(parseGitAuthor('renovate[bot]@users.noreply.github.com')).toEqual({
+        address: 'renovate[bot]@users.noreply.github.com',
+        name: 'renovate[bot]',
+      });
     });
     it('parses bot name and email', () => {
-      // FIXME: explicit assert condition
       expect(
         parseGitAuthor('renovate[bot] <renovate[bot]@users.noreply.github.com>')
-      ).toMatchInlineSnapshot(`
-        Object {
-          "address": "renovate[bot]@users.noreply.github.com",
-          "name": "renovate[bot]",
-        }
-      `);
+      ).toEqual({
+        address: 'renovate[bot]@users.noreply.github.com',
+        name: 'renovate[bot]',
+      });
     });
     it('escapes names', () => {
-      // FIXME: explicit assert condition
-      expect(
-        parseGitAuthor('name [what] <name@what.com>').name
-      ).toMatchInlineSnapshot(`"name [what]"`);
+      expect(parseGitAuthor('name [what] <name@what.com>').name).toEqual(
+        `name [what]`
+      );
     });
     it('tries again and fails', () => {
       expect(parseGitAuthor('foo<foo>')).toBeNull();

diff --git a/lib/util/git/index.spec.ts b/lib/util/git/index.spec.ts
@@ -111,8 +111,11 @@ describe('util/git/index', () => {
   });
   describe('getFileList()', () => {
     it('should return the correct files', async () => {
-      // FIXME: explicit assert condition
-      expect(await git.getFileList()).toMatchSnapshot();
+      expect(await git.getFileList()).toEqual([
+        'file_to_delete',
+        'master_file',
+        'past_file',
+      ]);
     });
     it('should exclude submodules', async () => {
       const repo = Git(base.path);
@@ -124,8 +127,12 @@ describe('util/git/index', () => {
       });
       await git.syncGit();
       expect(await fs.pathExists(tmpDir.path + '/.gitmodules')).toBeTruthy();
-      // FIXME: explicit assert condition
-      expect(await git.getFileList()).toMatchSnapshot();
+      expect(await git.getFileList()).toEqual([
+        '.gitmodules',
+        'file_to_delete',
+        'master_file',
+        'past_file',
+      ]);
       await repo.reset(['--hard', 'HEAD^']);
     });
   });
@@ -210,8 +217,7 @@ describe('util/git/index', () => {
       const branchFiles = await git.getBranchFiles(
         'renovate/branch_with_changes'
       );
-      // FIXME: explicit assert condition
-      expect(branchFiles).toMatchSnapshot();
+      expect(branchFiles).toEqual(['some-new-file']);
     });
   });
 
@@ -441,8 +447,10 @@ describe('util/git/index', () => {
 
   describe('getCommitMessages()', () => {
     it('returns commit messages', async () => {
-      // FIXME: explicit assert condition
-      expect(await git.getCommitMessages()).toMatchSnapshot();
+      expect(await git.getCommitMessages()).toEqual([
+        'master message',
+        'past message',
+      ]);
     });
   });
 
@@ -489,8 +497,10 @@ describe('util/git/index', () => {
 
       expect(git.branchExists('test')).toBeFalsy();
 
-      // FIXME: explicit assert condition
-      expect(await git.getCommitMessages()).toMatchSnapshot();
+      expect(await git.getCommitMessages()).toEqual([
+        'master message',
+        'past message',
+      ]);
 
       await git.checkoutBranch('develop');
 
@@ -503,7 +513,7 @@ describe('util/git/index', () => {
       await git.checkoutBranch('test');
 
       const msg = await git.getCommitMessages();
-      expect(msg).toMatchSnapshot();
+      expect(msg).toEqual(['past message2', 'master message', 'past message']);
       expect(msg).toContain('past message2');
     });