Skip to content

Commit

Permalink
feat: add dependencyDashboard to config:base
Browse files Browse the repository at this point in the history
Defaults dependencyDashboard=true for anyone using the config:base preset
  • Loading branch information
rarkins committed Aug 17, 2021
1 parent a09b85a commit 13532ec
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
7 changes: 1 addition & 6 deletions lib/config/presets/index.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -559,13 +559,8 @@ describe(getName(), () => {
const res = await presets.getPreset(':base', {});
expect(res).toEqual({
extends: [
':separateMajorReleases',
':combinePatchMinorReleases',
':ignoreUnstable',
':prImmediately',
':dependencyDashboard',
':semanticPrefixFixDepsChoreOthers',
':updateNotScheduled',
':automergeDisabled',
':ignoreModulesAndTests',
':autodetectPinVersions',
':prHourlyLimit2',
Expand Down
1 change: 1 addition & 0 deletions lib/config/presets/internal/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ export const presets: Record<string, Preset> = {
base: {
description: 'Default base configuration for all languages',
extends: [
':dependencyDashboard',
':semanticPrefixFixDepsChoreOthers',
':ignoreModulesAndTests',
':autodetectPinVersions',
Expand Down

4 comments on commit 13532ec

@mbrodala
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, what about the many other changes here? Aren't these beyond the scope of this commit?

@mbrodala
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I just saw a09b85a which is very likely the base. Still this commit looks confusing.

@rarkins
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit fixed up a test failure for the previous commit

@mbrodala
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks.

Please sign in to comment.