feat(config)!: non-zero defaults for PR concurrent, hourly limits (#1…

…9958)

Sets new defaults:
- `prConcurrentLimit`: 10 (instead of 0)
- `prHourlyLimit`: 2 (instead of 0)

Closes #19800

BREAKING CHANGE: Renovate now defaults to applying hourly and concurrent PR limits. To revert to unlimited, configure them back to `0`.

lib/config/options/index.ts

@@ -1579,16 +1579,16 @@ const options: RenovateOptions[] = [
   {
     name: 'prHourlyLimit',
     description:
-      'Rate limit PRs to maximum x created per hour. 0 (default) means no limit.',
+      'Rate limit PRs to maximum x created per hour. 0 means no limit.',
     type: 'integer',
-    default: 0, // no limit
+    default: 2,
   },
   {
     name: 'prConcurrentLimit',
     description:
-      'Limit to a maximum of x concurrent branches/PRs. 0 (default) means no limit.',
+      'Limit to a maximum of x concurrent branches/PRs. 0 means no limit.',
     type: 'integer',
-    default: 0, // no limit
+    default: 10,
   },
   {
     name: 'branchConcurrentLimit',

lib/config/presets/index.spec.ts

@@ -839,8 +839,6 @@ describe('config/presets/index', () => {
           ':dependencyDashboard',
           ':semanticPrefixFixDepsChoreOthers',
           ':ignoreModulesAndTests',
-          ':prHourlyLimit2',
-          ':prConcurrentLimit10',
           'group:monorepos',
           'group:recommended',
           'workarounds:all',

lib/config/presets/internal/config.ts

@@ -9,8 +9,6 @@ export const presets: Record<string, Preset> = {
       ':dependencyDashboard',
       ':semanticPrefixFixDepsChoreOthers',
       ':ignoreModulesAndTests',
-      ':prHourlyLimit2',
-      ':prConcurrentLimit10',
       'group:monorepos',
       'group:recommended',
       'workarounds:all',

lib/modules/platform/codecommit/index.md

@@ -133,7 +133,6 @@ module.exports = {
   password: 'SECRET_ACCESS_KEY_GOES_HERE',
   token: 'AWS_SESSION_TOKEN_GOES_HERE',
   gitAuthor: 'your_email@domain',
-  prConcurrentLimit: 10,
   packageRules: [
     {
       matchPackageNames: ['package_name', 'package_name2'],

lib/workers/repository/process/limits.spec.ts

@@ -43,13 +43,14 @@ describe('workers/repository/process/limits', () => {
     });
 
     it('returns prHourlyLimit if errored', async () => {
-      config.prHourlyLimit = 2;
+      config.prHourlyLimit = 5;
       platform.getPrList.mockRejectedValue('Unknown error');
       const res = await limits.getPrHourlyRemaining(config);
-      expect(res).toBe(2);
+      expect(res).toBe(5);
     });
 
     it('returns 99 if no hourly limit', async () => {
+      config.prHourlyLimit = 0;
       const res = await limits.getPrHourlyRemaining(config);
       expect(res).toBe(99);
     });
@@ -75,23 +76,24 @@ describe('workers/repository/process/limits', () => {
     });
 
     it('returns 99 if no concurrent limit', async () => {
+      config.prConcurrentLimit = 0;
       const res = await limits.getConcurrentPrsRemaining(config, []);
       expect(res).toBe(99);
     });
   });
 
   describe('getPrsRemaining()', () => {
     it('returns hourly limit', async () => {
-      config.prHourlyLimit = 5;
+      config.prHourlyLimit = 1;
       platform.getPrList.mockResolvedValueOnce([]);
       const res = await limits.getPrsRemaining(config, []);
-      expect(res).toBe(5);
+      expect(res).toBe(1);
     });
 
     it('returns concurrent limit', async () => {
-      config.prConcurrentLimit = 5;
+      config.prConcurrentLimit = 1;
       const res = await limits.getPrsRemaining(config, []);
-      expect(res).toBe(5);
+      expect(res).toBe(1);
     });
   });
 
@@ -122,9 +124,9 @@ describe('workers/repository/process/limits', () => {
       expect(res).toBe(99);
     });
 
-    it('returns 99 if no limits are set', () => {
+    it('returns 10 if no limits are set', () => {
       const res = limits.getConcurrentBranchesRemaining(config, []);
-      expect(res).toBe(99);
+      expect(res).toBe(10);
     });
 
     it('returns prConcurrentLimit if errored', () => {