Skip to content
This repository has been archived by the owner on Feb 9, 2024. It is now read-only.

fix(deps): downgrade to working CacheControl #367

Closed
wants to merge 1 commit into from

Conversation

languitar
Copy link

As a temporary measure to work around python-poetry/poetry#4688, downgrade CacheControl in the poetry virtualenv to a working version.

This fixes #366

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
As a temporary measure to work around python-poetry/poetry#4688, downgrade CacheControl in the poetry virtualenv to a working version.

This fixes renovatebot#366
Dockerfile Show resolved Hide resolved
@mkniewallner
Copy link

mkniewallner commented Nov 2, 2021

A new version of cachecontrol that should fix the issue has just been released, so it may not be necessary to merge this PR.
Fix PR: psf/cachecontrol#264
New release: https://github.com/ionrock/cachecontrol/releases/tag/v0.12.9

I tested on the Python image spawned by the slim one and it seemed to work well, while previously it didn't.
The Python image is not the same as the full one, but I believe that on the next version bump of Renovate library (which would trigger an image build), RUN install-tool poetry 1.1.11 will now install cachecontrol==0.12.9 which includes the fix.

@languitar
Copy link
Author

Nice that this was fixed soon enough upstream. So we close this PR?

@rarkins rarkins closed this Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current docker image ships a broken poetry installation
4 participants