Skip to content

Commit

Permalink
fix your mongodb tests with this one weird trick!
Browse files Browse the repository at this point in the history
Note the warning about unhelpful npm behaviour in this workspace
when the version of mongodb to test (by TAV) matches the version
installed for the instrumentation-mongoose workspace. The version
in instr-mongoose recently updated (in open-telemetry#2353), so it needs to
update here as well.
  • Loading branch information
trentm committed Aug 14, 2024
1 parent a8b520a commit 39558cd
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions plugins/node/opentelemetry-instrumentation-mongodb/.tav.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@ mongodb:
commands: npm run test-v3
- versions:
include: ">=4 <5"
# This version has been excluded because `mongoose` instrumentation has it
# pined as a transitive dependency.
# When `test-all-versions` tries to install it npm actually does nothing and
# we end up running tests for the wrong version (v6.5.0)
# This version has been excluded because `mongoose` instrumentation has
# it pinned as a transitive dependency. When `test-all-versions` tries
# to install it, **npm actually does nothing** and we end up running
# tests for the wrong version.
# Ref: https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2001#issuecomment-1992202942
exclude: "4.17.1"
exclude: "4.17.2"
commands: npm run test-v4
- versions: ">=5 <6"
commands: npm run test-v5-v6
Expand Down

0 comments on commit 39558cd

Please sign in to comment.