-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add action to test netlify functions #51
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ts-jest does not yet support Jest@28. Follow the issue here: <kulshekhar/ts-jest#3453>
Begin general dep cleanup
rendall
force-pushed
the
feature/github-actions
branch
3 times, most recently
from
May 2, 2022 14:04
7eed687
to
2ff5292
Compare
rendall
force-pushed
the
feature/github-actions
branch
from
May 2, 2022 14:07
2ff5292
to
901a79c
Compare
rendall
referenced
this pull request
in rendall-dev-Oy/simple-comment
May 4, 2022
* Fix gauth error * Allow headers on rejection / error response * Add Access-Control-Allow-Credential headers * Return "OK" for OPTION methods * Correct OPTION method to OPTIONS plural * Add Access-Control-Allow-Headers ... to Access-Control-Allow-Headers * Allow cross-origin script access * Add frontend script + webpack build * Allow gauth to retrieve token * Update apiClient * Create discussion area if not found * Add Referrer-Policy to CORS allowed headers * Create discussion div if not found * Add CSS distributable Note this is not acceptable for production, since it adds styles directly to elements like 'body' * Include credentials for all requests * Improve message for modify admin error * Remove unused * Set SameSite to None * Limit recursion on error * Immediate login after signup * Allow Authorization header * Show user id in logged-in status * Set SameSite to None at auth delete (log out) * Add #user-display to DOM * Remove js based Referrer Policy header * Add nice-to-haves * Add source-map to x-origin script * Improve user endpoint error messages * Troubleshoot missing auth * Do not ignore jwt expiration * Equalize expiration date between cookie and token * Login request on expire From a UXD perspective, this is less than optimal, but let's punt handling this until the frontend update * Expire auth in 1 year * Hide log-in form * Handle expired token server-side Just return 'null' * Hide user auth * Update jwt expiration * Add login before comment submit * Fix jwt expiration error * Hide user display * Hide user-display * Update x-origin css * Add JSDocs * Set API URL via setSimpleCommentApiUrl() * Guests can update / change name * Clear type errors * Add helpful error message * Use proper endpoint for userPUT * Update badge * Update badge * Update done and todo * Remove extraneous html elements * Add Twitter card logo * Cleanup * API URL as .env variable * Remove StyleCI Default open-source license is for PHP only, unnecessary as this project does not use PHP * Update README.md * Update README.md * Remove extraneous obsolete .env variables * Update basic description * Rewrite demo intro * Write more positive intro * Clean layout with detail-summary accordion * Remove help cursor from anchors with [title] Not having the cursor:pointer is potentially confusing * Add 'alternative solution' pros-cons lists * Add build dependencies to "dependencies" * Install Cypress * Close issue #35 `Frontend testing with Cypress` Merging this branch will include Cypress and essential tests for Simple Comment frontend * Initial documentaion and tests * Update '#simple-comment-area' to '...-display' * Update frontend element nomenclature Element ids with '-input' or '-textarea' changed to generic '-field' "#simple-comment-area" changed to more specific "...-display" * Change .env SIMPLE_COMMENT_MODE to IS_CROSS_SITE This change clarifies its purpose * Minimal functionality frontend test * Complete CYPRESS doc * Test client input validation * Create LICENSE Punt the question to readers * Add more alternatives! * AGPL 3 * Update abstract Service tests Upgraded TypeScript no longer compiles abstract classes, so Service must be implemented as TestService * Upgrade dependencies * Remove bson It's a dependency's dependency * Upgrade TypeScript to 4.4.3 * Fix module reference * Update landing page styling * Format Service.ts * Update dependencies (#44) * Fix type error * Upgrade dependencies * Update dependencies (#46) * Change `IS_CROSS_SITE` instructions to boolean fixes #47 * Update example.env List env variables in order they appear in Netlfify (alphabetical) * Remove David badge * Update secrets test * Set Node version * Upgrade mongodb client to latest minor version * Address Dependabot alerts * Implement SECURITY policy * Create codeql.yml * Upgrade/dependencies (#50) * Upgrade dependencies to latest where possible * `mongodb@3.7.3` => `mongodb@^4.5.0` * `typescript@4.3.5` => `typescript@^4.6.3` * Update failing Cypress tests * Lighthouse update * Remove netlify-lambda build tool * mitigate glob-parent vulnerability. * Update SECURITY.md * Add action to test netlify functions (#51) * Downgrade to Jest@27 ts-jest does not yet support Jest@28. Follow the issue here: <kulshekhar/ts-jest#3453> * Move cypress and netlify to optionalDep Begin general dep cleanup * Enforce unix-style endings * Add netlify-api-test GitHub action * Move aws-lambda to devDeps * Create test .env in CI * Remove swagger-generated API docs (#52) * Update/cleanup (#53) * Fix async security alert * Change interfaces to types * Update slug * Move mock data to its own file * Reset mocks after each test * Update/cleanup (#54) * Update mock data function names * Add eslint * Format * Add eslint-watch * Implement linter advice * Configure linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.