Skip to content

Commit

Permalink
Revert "Update z-index hierarchy (WordPress#65626)"
Browse files Browse the repository at this point in the history
This reverts commit 5c51436.
  • Loading branch information
renatho authored Oct 11, 2024
1 parent 26dfcb9 commit 555bb74
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
8 changes: 5 additions & 3 deletions packages/base-styles/_z-index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,12 @@ $z-layers: (
".interface-interface-skeleton__header": 30,
".interface-interface-skeleton__content": 20,
".edit-widgets-header": 30,
".wp-block-cover__inner-container": 1, // InnerBlocks area inside cover image block.
".wp-block-cover.is-placeholder .components-placeholder.is-large": 1, // Cover block resizer component inside a large placeholder.
".wp-block-cover.has-background-dim::before": 0, // Overlay area inside block cover need to be higher than the video background.
".wp-block-cover__image-background": -1, // Image background inside cover block.
".wp-block-cover__video-background": -1, // Video background inside cover block.
".wp-block-cover.has-background-dim::before": 1, // Overlay area inside block cover need to be higher than the video background.
".block-library-cover__padding-visualizer": 2, // BoxControl visualizer needs to be +1 higher than .wp-block-cover.has-background-dim::before
".wp-block-cover__image-background": 0, // Image background inside cover block.
".wp-block-cover__video-background": 0, // Video background inside cover block.
".wp-block-template-part__placeholder-preview-filter-input": 1,

// Fixed position appender:
Expand Down
1 change: 1 addition & 0 deletions packages/block-library/src/cover/editor.scss
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
// Shown while media is being uploaded
.components-spinner {
position: absolute;
z-index: z-index(".wp-block-cover__inner-container");
top: 50%;
left: 50%;
transform: translate(-50%, -50%); // Account for spinner dimensions
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/cover/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@
}

.wp-block-cover__inner-container {
position: relative;
width: 100%;
z-index: z-index(".wp-block-cover__inner-container");
color: inherit;
// Reset the fixed LTR direction at the root of the block in RTL languages.
/*rtl:raw: direction: rtl; */
Expand Down

0 comments on commit 555bb74

Please sign in to comment.