Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Unhandled exception: Crash on update #19

Closed
BubbaWPro opened this issue Jan 14, 2016 · 3 comments
Closed

Unhandled exception: Crash on update #19

BubbaWPro opened this issue Jan 14, 2016 · 3 comments

Comments

@BubbaWPro
Copy link

Description: Began updating, after the files appeared to have finished downloading, a few seconds pass, and the program crashes. This was the first time I had used the launcher since 0.3. Assuming you see this, keep up the good work bro. I'm running Windows 7 64.
Version: 0.6.5
Type: <class 'OSError'>
Value: [WinError 145] The directory is not empty: 'C:\Users\ADMIN\Desktop\CDDA\previous_version\lang\mo\it_IT'
Traceback:

  File "C:\Users\Remy\Projects\CDDA-Game-Launcher\cddagl\ui.py", line 1435, in download_http_finished
  File "C:\Users\Remy\Projects\CDDA-Game-Launcher\cddagl\ui.py", line 1451, in backup_current_game
  File "c:\python34\lib\shutil.py", line 482, in rmtree
  File "c:\python34\lib\shutil.py", line 372, in _rmtree_unsafe
  File "c:\python34\lib\shutil.py", line 372, in _rmtree_unsafe
  File "c:\python34\lib\shutil.py", line 372, in _rmtree_unsafe
  File "c:\python34\lib\shutil.py", line 381, in _rmtree_unsafe
  File "c:\python34\lib\shutil.py", line 379, in _rmtree_unsafe

@remyroy
Copy link
Owner

remyroy commented Jan 14, 2016

I don't think there is much we can do for this type of error. It seems we cannot remove that directory because it it being used by another process. I think the solution will be to try to find out which process it is and ask the user to retry the operation or cancel the update.

I'll try to add the message box soon.

@remyroy
Copy link
Owner

remyroy commented Jan 14, 2016

The use of the psutil package could be useful here. I'm leaving a note for myself.

@remyroy
Copy link
Owner

remyroy commented Jan 17, 2016

This is fixed with 3f2d6b3. There will now be a retry message box shown if we cannot remove the previous_version directory. That message box will show if a specific process is holding a handle on a contentious file or directory.

This fix will be part of the next release.

@remyroy remyroy closed this as completed Jan 17, 2016
hexagonrecursion pushed a commit to hexagonrecursion/CDDA-Game-Launcher that referenced this issue Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants