Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package.main with -- arguments #1773

Merged
merged 3 commits into from
Oct 4, 2020
Merged

fix: package.main with -- arguments #1773

merged 3 commits into from
Oct 4, 2020

Conversation

remy
Copy link
Owner

@remy remy commented Oct 4, 2020

Fixes #1758

The combination of using a package.main (which sets the script position to index zero) and using the -- stop slurp meant that the arguments had the script appended to the end instead of prepended to the start. The net result meant that when the script was forked, it would drop the first user arg.

See diff for details of the fix - a simple check against null.

Fixes #1758

The combination of using a package.main (which sets the script
position to index zero) and using the -- stop slurp meant that
the arguments had the script appended to the end instead of
prepended to the start. The net result meant that when the script
was forked, it would drop the first user arg.

See diff for details of the fix - a simple check against null.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nodemon .\src\server.js first second vs nodemon first second help...
1 participant