Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect changes in JSON files #643

Closed
pensierinmusica opened this issue Sep 21, 2015 · 2 comments · Fixed by #695
Closed

Detect changes in JSON files #643

pensierinmusica opened this issue Sep 21, 2015 · 2 comments · Fixed by #695

Comments

@pensierinmusica
Copy link
Contributor

Hi,

I'm using nodemon (v1.6.1) with Node (v4.1.0), it works perfectly but it doesn't detect changes in any ".json" files. Is this default behavior? How can it be changed?

Since in a server environment JSON files usually contain some settings, imho nodemon should restart by default when the content of a JSON file is changed.

Looking forward to hear your feedback, thanks!
@pensierinmusica pensierinmusica mentioned this issue Sep 21, 2015
Closed
@remy
Copy link
Owner

remy commented Sep 21, 2015

I wouldn't normally agree since you have it documented here https://github.com/remy/nodemon/blob/master/README.md#specifying-extension-watch-list but if you fix your commits I'll merge.

@pensierinmusica
Copy link
Contributor Author

Hi @remy, thanks, I hope it's fixed now! Let me know if it all looks good to you, cheers :)

@remy remy closed this as completed in cd4201a Sep 21, 2015
This was referenced Oct 19, 2015
Merged
Merged
remy pushed a commit that referenced this issue Oct 25, 2015
@pensierinmusica @remy
feat: add JSON to default watched extensions
370d778 
Since in a server environment JSON files often contain settings,
nodemon should restart by default when the content of a JSON file is changed.

Closes #643
mef added a commit to mef/nodemon that referenced this issue Aug 11, 2018
@mef
Documented remy#643 change inside help.txt
8d310ce 
Small update so that `nodemon -h` mentions that `.json` files are now watched by default.

P.S. The change fixing remy#643 may have been considered as a breaking change, and reflected by bumping major version number. Updating some apps to above nodemon v1.7.0 require adaptation of the config...
P.S.S. Thanks for creating nodemon, super useful piece of software.
mef added a commit to mef/nodemon that referenced this issue Aug 11, 2018
@mef
docs: update help.txt
b0aa016 
Small update so that `nodemon -h` mentions that `.json` files are now watched by default (this is the case since v1.7.0 -  remy#643)

P.S.: one remark: the change fixing remy#643 may have been considered as a breaking change, and reflected by bumping major version number. Updating some apps to nodemon v1.7.0+ require adaptation of the config...
P.P.S. Thanks for creating nodemon, super useful piece of software.
@mef mef mentioned this issue Aug 11, 2018
Merged
remy pushed a commit that referenced this issue Aug 11, 2018
@mef @remy
docs: update help.txt (#1401)
b8ff6b4 
Small update so that `nodemon -h` mentions that `.json` files are now watched by default (this is the case since v1.7.0 -  #643)

P.S.: one remark: the change fixing #643 may have been considered as a breaking change, and reflected by bumping major version number. Updating some apps to nodemon v1.7.0+ require adaptation of the config...
P.P.S. Thanks for creating nodemon, super useful piece of software.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: JSON extension not watched when "scriptExt" is defined
2 participants
@remy @pensierinmusica