Merge pull request #4440 from remotion-dev/media-parser-memory-leak

remotion-dev · Oct 30, 2024 · 61841d8 · 61841d8
2 parents 6694007 + df460ce
commit 61841d8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/packages/media-parser/src/parse-media.ts b/packages/media-parser/src/parse-media.ts
@@ -143,6 +143,8 @@ export const parseMedia: ParseMedia = async ({
 				);
 			}
 
+			currentReader.abort();
+
 			const {reader: newReader} = await readerInterface.read(
 				src,
 				parseResult.skipTo,

diff --git a/packages/media-parser/src/readers/from-web-file.ts b/packages/media-parser/src/readers/from-web-file.ts
@@ -40,10 +40,13 @@ export const webFileReader: ReaderInterface = {
 
 		return new Promise((resolve, reject) => {
 			reader.onload = () => {
+				const stream = part.stream();
+				const streamReader = stream.getReader();
 				resolve({
 					reader: {
-						reader: part.stream().getReader(),
+						reader: streamReader,
 						abort() {
+							streamReader.cancel();
 							controller.abort();
 						},
 					},
-Original file line number
+Diff line change
@@ Expand Up / @@ -143,6 +143,8 @@ export const parseMedia: ParseMedia = async ({ @@
     				);
     			}
+    			currentReader.abort();
     			const {reader: newReader} = await readerInterface.read(
     				src,
     				parseResult.skipTo,
@@ Expand Down @@