Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): wait until app server is killed before starting a new app server #6289

Merged
merged 2 commits into from
May 3, 2023

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented May 3, 2023

Fixes #6283

Testing: Added a setTimeout locally to artificially delay p.kill to simulate a slow-to-kill process for the app server. Confirmed that this code was resilient and waited for process to be killed before proceeding to spin up new app server instance and that EADDRINUSE was not encountered.

@changeset-bot
Copy link

changeset-bot bot commented May 3, 2023

🦋 Changeset detected

Latest commit: 0004c51

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Patch
create-remix Patch
@remix-run/css-bundle Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori force-pushed the pedro/fix-dev-server-kill branch from f6609bd to 8b182d3 Compare May 3, 2023 02:32
@pcattori pcattori changed the title wip fix(dev): wait until app server is killed before starting a new app server May 3, 2023
@pcattori pcattori marked this pull request as ready for review May 3, 2023 02:52
@pcattori
Copy link
Contributor Author

pcattori commented May 3, 2023

Need to see if we can do better than taskkill on Windows: nodejs/node#12378

@pcattori pcattori marked this pull request as draft May 3, 2023 14:37
@pcattori pcattori force-pushed the pedro/fix-dev-server-kill branch from 5d418e3 to 0004c51 Compare May 3, 2023 14:57
@pcattori pcattori marked this pull request as ready for review May 3, 2023 14:58
@pcattori pcattori merged commit 16cfda8 into dev May 3, 2023
@pcattori pcattori deleted the pedro/fix-dev-server-kill branch May 3, 2023 15:17
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.16.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant