Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(remix-server-runtime): remove react & react-dom from peerDependencies #4801

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Dec 7, 2022

Follow-up of #4731


Closes #1707
Closes #3461

@changeset-bot
Copy link

changeset-bot bot commented Dec 7, 2022

🦋 Changeset detected

Latest commit: d2ec031

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/server-runtime Minor
@remix-run/cloudflare Minor
@remix-run/deno Minor
@remix-run/dev Minor
@remix-run/node Minor
@remix-run/react Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
create-remix Minor
@remix-run/css-bundle Minor
@remix-run/architect Minor
@remix-run/express Minor
@remix-run/netlify Minor
@remix-run/testing Minor
@remix-run/vercel Minor
@remix-run/serve Minor
remix Minor
@remix-run/eslint-config Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MichaelDeBoey MichaelDeBoey force-pushed the move-react-to-peer-dependencies-of-testing-package branch from e58b21e to c450d9d Compare December 8, 2022 02:45
@MichaelDeBoey MichaelDeBoey force-pushed the move-react-to-peer-dependencies-of-testing-package branch from c450d9d to c117cd7 Compare December 21, 2022 18:41
@MichaelDeBoey MichaelDeBoey force-pushed the move-react-to-peer-dependencies-of-testing-package branch 2 times, most recently from 63ef6ad to e7e52bf Compare January 21, 2023 14:23
@MichaelDeBoey
Copy link
Member Author

@brophdawg11 @mcansh Anything that's preventing us from merging this one?

@MichaelDeBoey MichaelDeBoey force-pushed the move-react-to-peer-dependencies-of-testing-package branch from e7e52bf to d2ec031 Compare January 22, 2023 01:45
@pcattori pcattori merged commit abf34ba into remix-run:dev Jan 23, 2023
@MichaelDeBoey MichaelDeBoey deleted the move-react-to-peer-dependencies-of-testing-package branch January 23, 2023 16:41
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-8346ace-20230124 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.12.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants