Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler): officially support Deno #3117

Merged
merged 8 commits into from
May 17, 2022
Merged

feat(compiler): officially support Deno #3117

merged 8 commits into from
May 17, 2022

Commits on May 17, 2022

  1. docs(decisions): use npm to manage NPM dependencies for Deno projects

    @pcattori
    pcattori committed May 17, 2022
    Configuration menu
    Copy the full SHA
    e0c70df View commit details
    Browse the repository at this point in the history

  2. refactor(compiler): do not bundle url imports 

    keep url imports as-is in build output so that each runtime can handle url imports in their own way.
for example, deno will download dependencies from url imports at runtime. the browser will download
dependendencies from url imports on-demand. node will simply throw an error when encountering a url
import.

since we will recommend to use npm/node_modules for dependency
management (even for deno), the only url imports we expect are for deno
imports on the server from https://deno.land or from Deno-friendly CDNs
like https://esm.sh .
    @pcattori
    pcattori committed May 17, 2022
    Configuration menu
    Copy the full SHA
    cc41d27 View commit details
    Browse the repository at this point in the history

  3. feat(compiler): can build deno-compatible server bundle

    @pcattori
    pcattori committed May 17, 2022
    Configuration menu
    Copy the full SHA
    a309ed7 View commit details
    Browse the repository at this point in the history

  4. feat(@remix-run/deno): add server runtime package for deno

    @pcattori
    pcattori committed May 17, 2022
    Configuration menu
    Copy the full SHA
    1269bca View commit details
    Browse the repository at this point in the history

  5. feat(templates/deno): use npm-managed dependencies

    @pcattori
    pcattori committed May 17, 2022
    Configuration menu
    Copy the full SHA
    5aba5d4 View commit details
    Browse the repository at this point in the history

  6. test(replace-remix-imports): fix shell.grep call 

    previously, `shell.grep` was being called with the `-r` option, which it does not recognize,
resulting in an exit ode of 1. we incorrectly interpreted that as `grep` finishing the search
without finding matches. instead, the `shell.grep` call was crashing. now we correctly pass a list
of files to `shell.grep` without the `-r` option.
    @pcattori
    pcattori committed May 17, 2022
    Configuration menu
    Copy the full SHA
    38efcad View commit details
    Browse the repository at this point in the history

  7. test(compiler): browser and server bundles for deno

    @pcattori
    pcattori committed May 17, 2022
    Configuration menu
    Copy the full SHA
    ba8bfb9 View commit details
    Browse the repository at this point in the history

  8. refactor(@remix-run/deno): throw custom error when static files are n… 

    …ot found

so that `createRequestHandlerWithStaticFiles` is more portable across runtimes and adapters
    @pcattori
    pcattori committed May 17, 2022
    Configuration menu
    Copy the full SHA
    1618391 View commit details
    Browse the repository at this point in the history