build: fix run-p glob matching for yarn > 2 .. #2033
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machour
added
the
needs-response
|
@CanRau thank you so much for opening this PR! 🙏🏼 Would you mind fixing the conflicts? The |
CanRau
added a commit
to CanRau/remix
that referenced
this pull request
Mar 20, 2022
Ref mysticatea/npm-run-all#200 Fix remix-run#2033 from: https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#type from: https://www.conventionalcommits.org/en/v1.0.0/ from: https://cheatography.com/albelop/cheat-sheets/conventional-commits/ from: https://gist.github.com/lisawolderiksen/a7b99d94c92c6671181611be1641c733
|
Closing in favor of #2417 |
github-actions
bot
removed
the
needs-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just ran into
No matches found: "dev:*"using Yarn 3Quoting it
"dev": "run-p 'dev:*'",like mentioned in the linked issue fixed it for me with Yarn 3 and also tested Yarn 1.22.10 and npm 8.1.0, just to make sure.So I figured as it shouldn't break anything why not always quote it?
Please correct me if I'm mistaken 🙏