refactor(@remix-run/node): implement crypto-dependent interface funct…

…ions

packages/remix-node/crypto.ts

@@ -0,0 +1,16 @@
+import cookieSignature from "cookie-signature";
+import type {
+  SignFunction,
+  UnsignFunction,
+} from "@remix-run/server-runtime";
+
+export const sign: SignFunction = async (value, secret) => {
+  return cookieSignature.sign(value, secret);
+};
+
+export const unsign: UnsignFunction = async (
+  signed: string,
+  secret: string
+) => {
+  return cookieSignature.unsign(signed, secret);
+};

packages/remix-node/globals.ts

@@ -1,11 +1,6 @@
-import type {
-  InternalSignFunctionDoNotUseMe,
-  InternalUnsignFunctionDoNotUseMe,
-} from "@remix-run/server-runtime/cookieSigning";
 import { Blob as NodeBlob, File as NodeFile } from "@web-std/file";
 
 import { atob, btoa } from "./base64";
-import { sign as remixSign, unsign as remixUnsign } from "./cookieSigning";
 import {
   Headers as NodeHeaders,
   Request as NodeRequest,
@@ -32,11 +27,6 @@ declare global {
       Response: typeof Response;
       fetch: typeof fetch;
       FormData: typeof FormData;
-
-      // TODO: Once node v16 is available on AWS we should remove these globals
-      // and provide the webcrypto API instead.
-      sign: InternalSignFunctionDoNotUseMe;
-      unsign: InternalUnsignFunctionDoNotUseMe;
     }
   }
 }
@@ -53,7 +43,4 @@ export function installGlobals() {
   global.Response = NodeResponse as unknown as typeof Response;
   global.fetch = nodeFetch as unknown as typeof fetch;
   global.FormData = NodeFormData as unknown as typeof FormData;
-
-  global.sign = remixSign;
-  global.unsign = remixUnsign;
 }

packages/remix-node/implementations.ts

@@ -0,0 +1,13 @@
+import {
+  createCookieFactory,
+  createCookieSessionStorageFactory,
+  createMemorySessionStorageFactory,
+  createSessionStorageFactory,
+} from "@remix-run/server-runtime";
+
+import { sign, unsign } from "./crypto";
+
+export const createCookie = createCookieFactory({ sign, unsign });
+export const createCookieSessionStorage = createCookieSessionStorageFactory(createCookie);
+export const createSessionStorage = createSessionStorageFactory(createCookie);
+export const createMemorySessionStorage = createMemorySessionStorageFactory(createSessionStorage);

packages/remix-node/index.ts

@@ -31,9 +31,12 @@ export {
   createCookie,
   createCookieSessionStorage,
   createMemorySessionStorage,
+  createSessionStorage,
+} from './implementations';
+
+export {
   createRequestHandler,
   createSession,
-  createSessionStorage,
   isCookie,
   isSession,
   json,

packages/remix-node/sessions/fileStorage.ts

@@ -5,7 +5,8 @@ import type {
   SessionStorage,
   SessionIdStorageStrategy,
 } from "@remix-run/server-runtime";
-import { createSessionStorage } from "@remix-run/server-runtime";
+
+import { createSessionStorage } from "../implementations";
 
 interface FileSessionStorageOptions {
   /**