fix(router): url encode file names #9867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6f885d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 task
jenseng
force-pushed
the
fix-url-encoded-files
branch
from
7913b1f
to
e561e37
Compare
brophdawg11
reviewed
Jan 11, 2023
brophdawg11
reviewed
Jan 11, 2023
brophdawg11
reviewed
Jan 11, 2023
brophdawg11
reviewed
Jan 11, 2023
brophdawg11
reviewed
Jan 11, 2023
brophdawg11
reviewed
Jan 11, 2023
brophdawg11
reviewed
Jan 11, 2023
This is the RR port of remix-run/remix#4473 Bring FormData serialization in line with the spec with respect to File entries in url-encoded payloads: send the `name` as the value, as is the case with a vanilla `<form>` submission. Rework various 400-error tests not to rely on the old behavior, as it's no longer a bad request :) References: remix-run/remix#4342 Spec: https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#convert-to-a-list-of-name-value-pairs
jenseng
force-pushed
the
fix-url-encoded-files
branch
from
e561e37
to
bf281ed
Compare
jenseng
commented
Jan 12, 2023
|
Thanks @jenseng! |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the RR port of remix-run/remix#4473
Bring FormData serialization in line with the spec with respect to File entries in url-encoded payloads: send the
nameas the value, as is the case with a vanilla<form>submission.Rework various 400-error tests not to rely on the old behavior, as it's no longer a bad request :)
References: remix-run/remix#4342
Spec: https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#convert-to-a-list-of-name-value-pairs