fix: Minor updates for 6.4.0-pre.2 reports #8939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brophdawg11
force-pushed
the
brophdawg11/remixing-updates
branch
from
c59e059 to
78ffc88
Compare
brophdawg11
commented
Jun 6, 2022
| <DataBrowserRouter | ||
| window={getWindow("/foo")} | ||
| hydrationData={{}} | ||
| fallbackElement={<span />} |
There was a problem hiding this comment.
Now that fallbackElement is optional we don't need these props in all of our tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor updates + cleanup in preparation for
6.4.0-pre.3use-sync-external-storedependency inpackage.jsonfallbackElementtype toReactNodefor more flexible typing (REM-1146)fallbackElementoptional for SSR use-case and to match what the docs currently show ([Bug]:DataBrowserRouter'sfallbackElementprop is required #8896)actionResultthrough to shouldRevalidate on fetcher submissions (REM-1159)packages/router/README.mdup to dateCloses: #8896