Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavLink: add inactiveClassName and inactiveStyle props #7979

Closed
wants to merge 2 commits into from

Conversation

chaance
Copy link
Collaborator

@chaance chaance commented Aug 30, 2021

This PR adds two new props for v5 to add an optional class name and style prop when a NavLink is inactive. Resolves #7194.

@chaance chaance requested a review from mjackson August 30, 2021 20:29
@chaance chaance closed this Aug 31, 2021
@timdorr
Copy link
Member

timdorr commented Aug 31, 2021

Why did this get closed? I know some folks were looking forward to it.

@chaance
Copy link
Collaborator Author

chaance commented Aug 31, 2021

@timdorr Michael and I discussed an alternative API this morning that will make migrating to v6 a little smoother. I'll have another PR up here in just a bit for that one!

@chaance
Copy link
Collaborator Author

chaance commented Aug 31, 2021

@timdorr see #7983

@chaance chaance deleted the navlink-inactive-props branch September 1, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove inactive classes from NavLink
2 participants