Refactor react-native tests to TS
#7914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaance
commented
Jul 21, 2021
| @@ -41,7 +41,7 @@ | |||
| "eslint-plugin-import": "^2.23.4", | |||
| "eslint-plugin-jsx-a11y": "^6.4.1", | |||
| "eslint-plugin-react": "^7.24.0", | |||
| "eslint-plugin-react-hooks": "^4.2.0", | |||
| "eslint-plugin-react-hooks": "next", | |||
There was a problem hiding this comment.
There is a bug in the latest stable eslint-plugin-react-hooks that causes an annoying error popup every time you write a useEffect in VS Code. This was fixed in the next release (details here). Watching for the next patch release to update the dependency here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty straight forward I believe, but this should also improve some of the types we're exposing to consumers as well.