Make match set the location as history entry when creating new memory history object

[denvned]

I believe, this is a proper fix for denvned/isomorphic-relay-router#26.

[psalz]

typo in entries

[denvned]

Fixed. Thanks!

[taion]

This was previously rejected as #3089. We explicitly don't want to set the history location here – the history should be treated as a stateless (and potentially reusable) object that otherwise holds no state.

[denvned]

the history should be treated as a stateless (and potentially reusable) object that otherwise holds no state.

@taion, But this PR code does not change state of the history, it only provides the location to createMemoryHistory. Without that, createMemoryHistory defaults location to some meaningless value (/)... I really don't understand why the latter is considered correct behaviour, and why I should use hacks like https://github.com/denvned/isomorphic-relay-router/blob/v0.7.0-beta.1/src/prepareData.js#L6-L7.

[timdorr]

I'm with @denvned here. The history isn't stateless by default and that is causing issues for people that assume the defaults are consistent (they are not).

[taion]

Can you clarify how this is coming up? I don't think user code on the SSR path should be touching the history at all, beyond using it to create hrefs if needed.

[timdorr]

It's not directly. It's touching router from renderProps. Here's something that could be turned into a breaking case:

match({ routes, location: '/test' }, function (error, redirectLocation, renderProps) {
  renderProps.router.listen(loc => expect(loc.pathname).toEqual('/test')) // Fails. This equals '/'
})

[taion]

I think that, when rendering on the server, you should not be able to call listen, push, or replace with the implicit history-like-object that we create.