Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prerendering when using a custom server #12759

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

brophdawg11
Copy link
Contributor

Closes #12758

Copy link

changeset-bot bot commented Jan 16, 2025

🦋 Changeset detected

Latest commit: c5cf1f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-router/dev Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch
react-router Patch
react-router-dom Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kennygoff
Copy link

Tested this on my netlify site that was having issues. Local build works and was able to prerender various pages 👍

@lazuee
Copy link

lazuee commented Jan 19, 2025

I've confirmed that this resolves the issue with prerendering when changing the server-build entry filename.

whale_5lXrXkbQiz.mp4

@brophdawg11 brophdawg11 merged commit ca45788 into dev Jan 21, 2025
7 of 8 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/prerender-custom-server branch January 21, 2025 15:00
@brophdawg11
Copy link
Contributor Author

Thanks for testing @kennygoff and @lazuee!

Copy link
Contributor

🤖 Hello there,

We just published version 6.28.3-pre-v6.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 7.1.4-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I can't prerender when using cloudflare or cloudflare-d1 templates
3 participants