Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress v7 warnings in production build #12509

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Suppress v7 warnings in production build #12509

merged 3 commits into from
Jan 21, 2025

Conversation

rakleed
Copy link

@rakleed rakleed commented Dec 9, 2024 •
edited
Loading

Closes #12250, see #12250 (comment)

I prefer to use default settings and as little configuration as possible, so it is good practice to follow generally accepted standards.

I did the same as it was done in MobX and Antd.

@brookslybrand

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 9, 2024

Hi @rakleed,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e629d6d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 9, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@rakleed
Copy link
Author

rakleed commented Dec 20, 2024

@brophdawg11 could you please review this PR before release 6.28.1?

@rakleed
Copy link
Author

rakleed commented Jan 15, 2025

@brookslybrand @brophdawg11 @pcattori @markdalgleish could you please review my PR?

@brophdawg11 brophdawg11 changed the base branch from v6 to brophdawg11/remove-deprecation-warnings-in-prod January 21, 2025 14:53
@brophdawg11
Copy link
Contributor

Thank you for the PR! I'm going to merge this to my own branch so I can add a changeset and get this merged

@brophdawg11 brophdawg11 merged commit 430037c into remix-run:brophdawg11/remove-deprecation-warnings-in-prod Jan 21, 2025
2 of 3 checks passed
@brophdawg11 brophdawg11 mentioned this pull request Jan 21, 2025
Merged
brophdawg11 added a commit that referenced this pull request Jan 21, 2025
@brophdawg11 @rakleed
Suppress v7 warnings in production build (#12794)
3fd082a 
* Suppress v7 warnings in production build (#12509)

* Don't log v7 deprecation warnings in prod builds

---------

Co-authored-by: Pavel <19418601+rakleed@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brophdawg11 brophdawg11 brophdawg11 left review comments

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rakleed @brophdawg11