Migrate Fog of War from Remix 2.10.0 #11735
Conversation
|
… in Fog of War (Remix PR 9624)
brophdawg11
force-pushed
the
brophdawg11/remix-2-10-0-fog-of-war
branch
from
96b3d7a to
460a0f3
Compare
|
🤖 Hello there, We just published version Thanks! |
7 similar comments
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
| patchRoutes: Router["patchRoutes"] | ||
| ): Promise<void> { | ||
| let { nextPaths, knownGoodPaths, known404Paths } = _fogOfWar; | ||
| let manifestPath = `${basename != null ? basename : "/"}/__manifest`.replace( |
There was a problem hiding this comment.
@brophdawg11 why force the path here so the manifest is always at root / path? This breaks apps with the ssr:false (in react-router.config.ts) and a base path set in vite.config.ts on react-router 7.1.3. The manifest.url has the correct URL but that's not being used.
Dependent on #11734