Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createPath: Prefix search and hash parts as needed. #820

Closed
wants to merge 1 commit into from
Closed

createPath: Prefix search and hash parts as needed. #820

wants to merge 1 commit into from

Conversation

StringEpsilon
Copy link

Fixes #813 by restoring the version 4 behavior.

This is technically a breaking change, but my interpretation is that the breaking change from v4 to v5 was not made intentionally. So this is just restoring the old (desired) behavior.

@StringEpsilon
Copy link
Author

Also fixes remix-run/react-router/issues/7496

@chaance chaance deleted the branch remix-run:master August 14, 2021 18:05
@chaance chaance closed this Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createPath no longer prefixes "search" and "hash" parameters
2 participants