Skip to content

Commit

Permalink
Fix warnings tests
Browse files Browse the repository at this point in the history
  • Loading branch information
TrySound authored and mjackson committed Oct 30, 2018
1 parent fe3b4d3 commit 499bef5
Show file tree
Hide file tree
Showing 6 changed files with 43 additions and 17 deletions.
26 changes: 26 additions & 0 deletions .size-snapshot.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
{
"esm/history.js": {
"bundled": 29711,
"minified": 12554,
"gzipped": 3612,
"treeshaked": {
"rollup": {
"code": 208,
"import_statements": 132
},
"webpack": {
"code": 1324
}
}
},
"umd/history.js": {
"bundled": 34521,
"minified": 12072,
"gzipped": 4080
},
"umd/history.min.js": {
"bundled": 32037,
"minified": 10205,
"gzipped": 3564
}
}
6 changes: 3 additions & 3 deletions modules/__tests__/TestSequences/PushSamePathWarning.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,16 @@ export default (history, done) => {
}
];

let consoleError = console.error; // eslint-disable-line no-console
let consoleWarn = console.error; // eslint-disable-line no-console
let warningMessage;

// eslint-disable-next-line no-console
console.error = message => {
console.warn = message => {
warningMessage = message;
};

execSteps(steps, history, (...args) => {
console.error = consoleError; // eslint-disable-line no-console
console.warn = consoleWarn; // eslint-disable-line no-console
done(...args);
});
};
6 changes: 3 additions & 3 deletions modules/__tests__/TestSequences/PushStateWarning.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,16 @@ export default (history, done) => {
}
];

let consoleError = console.error; // eslint-disable-line no-console
let consoleWarn = console.warn; // eslint-disable-line no-console
let warningMessage;

// eslint-disable-next-line no-console
console.error = message => {
console.warn = message => {
warningMessage = message;
};

execSteps(steps, history, (...args) => {
console.error = consoleError; // eslint-disable-line no-console
console.warn = consoleWarn; // eslint-disable-line no-console
done(...args);
});
};
6 changes: 3 additions & 3 deletions modules/__tests__/TestSequences/ReplaceStateWarning.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,16 @@ export default (history, done) => {
}
];

let consoleError = console.error; // eslint-disable-line no-console
let consoleWarn = console.warn; // eslint-disable-line no-console
let warningMessage;

// eslint-disable-next-line no-console
console.error = message => {
console.warn = message => {
warningMessage = message;
};

execSteps(steps, history, (...args) => {
console.error = consoleError; // eslint-disable-line no-console
console.warn = consoleWarn; // eslint-disable-line no-console
done(...args);
});
};
12 changes: 6 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
"@babel/runtime": "^7.1.2",
"loose-envify": "^1.2.0",
"resolve-pathname": "^2.2.0",
"tiny-invariant": "^1.0.1",
"tiny-warning": "^0.0.3",
"tiny-invariant": "^1.0.2",
"tiny-warning": "^1.0.0",
"value-equal": "^0.4.0"
},
"devDependencies": {
Expand Down

0 comments on commit 499bef5

Please sign in to comment.