fix: always stop before special stop methods

remedyred · Mar 30, 2023 · af15a17 · af15a17
1 parent 83ec63d
commit af15a17
Showing 1 changed file with 12 additions and 20 deletions.
diff --git a/packages/spinner/src/Spinner.class.ts b/packages/spinner/src/Spinner.class.ts
@@ -189,11 +189,9 @@ export class Spinner extends EventEmitter {
 	 * @param text
 	 */
 	finish(text?: string) {
-		if (this._started) {
-			this.#stop(text)
-			this.#renderLine(kLogSymbols.success)
-			this.emit('finished')
-		}
+		this.#stop(text)
+		this.#renderLine(kLogSymbols.success)
+		this.emit('finished')
 
 		return this
 	}
@@ -203,11 +201,9 @@ export class Spinner extends EventEmitter {
 	 * @param text
 	 */
 	fail(text?: string) {
-		if (this._started) {
-			this.#stop(text)
-			this.#renderLine(kLogSymbols.error)
-			this.emit('failed')
-		}
+		this.#stop(text)
+		this.#renderLine(kLogSymbols.error)
+		this.emit('failed')
 
 		return this
 	}
@@ -217,11 +213,9 @@ export class Spinner extends EventEmitter {
 	 * @param text
 	 */
 	stop(text?: string) {
-		if (this._started) {
-			this.#stop(text)
-			this.#renderLine(kLogSymbols.stop)
-			this.emit('stopped')
-		}
+		this.#stop(text)
+		this.#renderLine(kLogSymbols.stop)
+		this.emit('stopped')
 
 		return this
 	}
@@ -249,11 +243,9 @@ export class Spinner extends EventEmitter {
 	 * @param text
 	 */
 	warn(text?: string) {
-		if (this._started) {
-			this.#stop(text)
-			this.#renderLine(kLogSymbols.warning)
-			this.emit('warned')
-		}
+		this.#stop(text)
+		this.#renderLine(kLogSymbols.warning)
+		this.emit('warned')
 
 		return this
 	}