Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use npm workspaces #271

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Use npm workspaces #271

merged 2 commits into from
Aug 17, 2021

Conversation

wooorm
Copy link
Member

@wooorm wooorm commented Aug 17, 2021

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

This switches to npm workspaces.
npm workspaces are builtin and fast to install.
They also hoist node_modules, which lerna can do with --hoist, and solves GH-270.

Closes GH-270.

@wooorm wooorm added 🐛 type/bug This is a problem 👶 semver/patch This is a backwards-compatible fix 🏡 area/internal This affects the hidden internals 🏗 area/tools This affects tooling ☂️ area/types This affects typings labels Aug 17, 2021
@wooorm wooorm requested a review from ChristianMurphy August 17, 2021 11:30
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Aug 17, 2021
@codecov-commenter

This comment has been minimized.

@wooorm wooorm merged commit bc1b092 into main Aug 17, 2021
@github-actions

This comment has been minimized.

@wooorm wooorm deleted the npm-ws branch August 17, 2021 13:26
@wooorm wooorm added the 💪 phase/solved Post is done label Aug 17, 2021
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏡 area/internal This affects the hidden internals 🏗 area/tools This affects tooling ☂️ area/types This affects typings 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem
Development

Successfully merging this pull request may close these issues.

Import paths for generated type definitions broken
4 participants