Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gameobjects): remove sound on arrow keypress #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SG-SWE073
Copy link
Collaborator

What is the motivation for this pull request?

  • Fix

What is the current behavior?

  • On every keypress for the arrows, a sound is played that may distract some players from the music.

What is the new behavior?

  • The sound on keypress has been removed.

Checklist:

Copy link
Member

@remarkablemark remarkablemark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally like the sound effect because it provides feedback that the key is pressed

When I play tested the change, it felt like something was missing: https://zeroupdates.rhythmism.pages.dev/

What do you think?

@SG-SWE073
Copy link
Collaborator Author

SG-SWE073 commented Feb 20, 2024

Now that I consider it more, there's a few things to note.

  • I also have that same feeling like something is missing with the sound gone, but I think that is partly because we got used to hearing the sound so often in development, that the absence of it is a bit uncomfortable.
  • So I'm thinking if this were to be removed, what else could be done differently? So I started to look at Guitar Hero and Stepmania for how they do things.
  • Guitar Hero: (video: https://www.youtube.com/watch?v=lHPDP-q3EIY ). There isn't any audio played when the notes are correct, but there is audio when the wrong notes are played. ( Wrong note: https://www.youtube.com/watch?v=nYxL7JXHjLY ). There are instead visual cues that the player is in sync with the song ( The buttons are floating, spark animation, score going up etc. ).
  • Stepmania: (video: https://www.youtube.com/watch?v=hjiz0ojsSu4 ). See the same thing happen with the visual cues.

So with this in mind, maybe we can hold off on the merge until we get more feedback from others, and if other players mention the sound is distracting, then we can discuss the update further.

@remarkablemark
Copy link
Member

@SG-SWE073 sounds goods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants