Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to React 18 #840

Merged
merged 11 commits into from
Jun 2, 2024
Merged

Migrate to React 18 #840

merged 11 commits into from
Jun 2, 2024

Conversation

L4Ph
Copy link
Contributor

@L4Ph L4Ph commented Jun 2, 2024

  1. react / react-dom / @types/react / @types/react-dom のアップグレード
  2. index.tsxのReactDOM.renderを廃止し、React18から採用されたcreateRootへ変更(また、React19からはReactDOM.renderは完全に廃止されます。)
  3. React 18へのアップグレードにより、Connect()周りでエラーを発生していたため、react-reduxをアップグレード
  4. React 18へのアップグレードにより、OrganizationManagement.tsx / Configure.tsx 等で発生していた、Snackbarの型エラーを修正
  5. React18へのアップグレードにより、<HelmetProvider>で型エラーが発生していたため、react-helmet-asyncをアップグレード
  6. React18へのアップグレードにより、<ImageGallery>で型エラーが発生していたため、react-image-galleryをアップグレードし、yarn.lockを再構築

@L4Ph L4Ph changed the title Migrate React 18 Migrate to React 18 Jun 2, 2024
Copy link
Collaborator

@yoichiro yoichiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@L4Ph LGTM. Thanks!

@yoichiro yoichiro merged commit cab1b8f into remap-keys:main Jun 2, 2024
1 check passed
@L4Ph L4Ph deleted the upgrade-react-18 branch June 2, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants