Skip to content
This repository has been archived by the owner on Dec 5, 2023. It is now read-only.

Commit

Permalink
Align fees url
Browse files Browse the repository at this point in the history
In an attempt to streamline the fee url to a single field from Drupal, we wan to use the feesAndCompensationRatesUrl instead. materialOverdueUrl has been depricated and removed from Drupal
  • Loading branch information
JacobArrow committed Nov 28, 2023
1 parent a95f344 commit 5bbce3b
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 8 deletions.
4 changes: 0 additions & 4 deletions src/apps/loan-list/list/loan-list.dev.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@ export default {
...materialDetailsModalArgs,
...blockedArgs,
// Config
materialOverdueUrl: {
defaultValue: "https://unsplash.com/photos/wd6YQy0PJt8", // open source image of a red panda
control: { type: "text" }
},
pageSizeDesktop: {
defaultValue: 10,
control: { type: "number" }
Expand Down
1 change: 0 additions & 1 deletion src/apps/loan-list/list/loan-list.entry.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ export interface LoanListEntryConfigProps {
expirationWarningDaysBeforeConfig: string;
}
export interface LoanListEntryUrlProps {
materialOverdueUrl: string;
expirationWarningDaysBeforeConfig: string;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ const MaterialOverdueLink: FC<MaterialOverdueLinkProps> = ({
dueDate,
showOn
}) => {
const { materialOverdueUrl } = useUrls();
const { viewFeesAndCompensationRatesUrl } = useUrls();
const t = useText();
if (!dueDate || (dueDate && !materialIsOverdue(dueDate))) return null;

return (
<Link
href={materialOverdueUrl}
href={viewFeesAndCompensationRatesUrl}
className={`list-reservation__note list-reservation__note--${showOn} color-signal-alert`}
>
{t("loanListMaterialLateFeeText")}
Expand Down
1 change: 0 additions & 1 deletion src/core/utils/types/global-url-props.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ interface GlobalUrlEntryPropsInterface {
advancedSearchUrl: string;
fbsBaseUrl: string;
loanListEreolenUrl: string;
materialOverdueUrl: string;
feesPageUrl: string;
publizonBaseUrl: string;
dplCmsBaseUrl: string;
Expand Down

0 comments on commit 5bbce3b

Please sign in to comment.