Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pr_body field #1778

Merged
merged 10 commits into from
Oct 18, 2024
Merged

feat: add pr_body field #1778

merged 10 commits into from
Oct 18, 2024

Conversation

JustBeYou
Copy link
Contributor

Closes #1741

@JustBeYou
Copy link
Contributor Author

hi @marcoieni , this should be ready for review, thanks!

marcoieni
marcoieni reviewed Oct 16, 2024
View reviewed changes
website/docs/config.md Outdated Show resolved Hide resolved
marcoieni
marcoieni reviewed Oct 16, 2024
View reviewed changes
website/docs/config.md Outdated Show resolved Hide resolved
marcoieni
marcoieni reviewed Oct 16, 2024
View reviewed changes
website/docs/config.md Outdated Show resolved Hide resolved
marcoieni
marcoieni reviewed Oct 16, 2024
View reviewed changes
website/docs/config.md Outdated Show resolved Hide resolved
@marcoieni
Copy link
Member

marcoieni commented Oct 16, 2024 •
edited
Loading

Looks great as always!!!!

Left a few small comments, I think we'll merge this one in no time as well :)

@JustBeYou JustBeYou requested a review from marcoieni October 17, 2024 08:48
@JustBeYou
Copy link
Contributor Author

Thanks! I made the changes.

marcoieni
marcoieni reviewed Oct 17, 2024
View reviewed changes
crates/release_plz/tests/all/release_pr.rs Outdated Show resolved Hide resolved
website/docs/config.md Show resolved Hide resolved
@JustBeYou
Copy link
Contributor Author

Fixed CR & rebased.

@JustBeYou JustBeYou requested a review from marcoieni October 18, 2024 18:19
marcoieni
marcoieni approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@marcoieni marcoieni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, awesome! ❤️

@marcoieni marcoieni enabled auto-merge (squash) October 18, 2024 19:46
@marcoieni marcoieni merged commit cbf1438 into release-plz:main Oct 18, 2024
12 checks passed
@release-plz release-plz bot mentioned this pull request Oct 18, 2024
Merged
@marcoieni marcoieni mentioned this pull request Oct 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoieni marcoieni marcoieni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add configuration field to customize the pr body
2 participants
@JustBeYou @marcoieni