fix: github orgs and ssh remote url parser #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axetroy
reviewed
Jan 20, 2022
| @@ -133,6 +139,15 @@ func Transform(g *client.GitClient, splices []*ExtractSplice) ([]*TemplateContex | |||
| if remoteURL, err = url.Parse(fmt.Sprintf("%s://%s%s", remoteURL.Scheme, remoteURL.Host, urlPath)); err != nil { | |||
| return nil, errors.WithStack(err) | |||
| } | |||
| case "file": | |||
There was a problem hiding this comment.
Can you provide an example URL for testing? I'm curious how it parses into the file protocol
There was a problem hiding this comment.
Our remotes look like: org-1232456@github.com:USER/REPO.git and the url parser utility doesn't really know how to deal with them: https://go.dev/play/p/7jUtvntFvdl
axetroy
reviewed
Jan 20, 2022
axetroy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was testing this with a private github organization, and given the string, the tool would have a nil pointer exception at the re-parsing phase of getting the commitUrl.
Added:
fileThis is definitely a rough fix, but something I tested while debugging the issue.