This repository has been archived by the owner on Aug 1, 2023. It is now read-only.
Updated sync to always copy new images and manifests to HIDDEN repo #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twaugh
added a commit
to containerbuildsystem/atomic-reactor
that referenced
this pull request
Jun 22, 2016
The dockpulp syncRepo() method no longer returns the prefixed repository ID. As pulp_sync can be told what the prefix is, let's just use that to work out what the prefixed repository ID is. dockpulp change: release-engineering/dockpulp#59
| else: | ||
| oldmanifests = repoinfo['manifests'].keys() | ||
|
|
||
| repoinfo = self.listRepos(repo, True) |
There was a problem hiding this comment.
Don't you already have this from line 879?
There was a problem hiding this comment.
Oh, you need to do it twice to see which units are new, I see now.
|
Now that syncRepo() no longer returns the repository ID I've adjusted atomic-reactor's pulp_sync plugin so that it doesn't rely on that. Instead it finds out the prefix from a configuration parameter and works out the repository ID from that. Even better would be for dockpulp to be able to tell it the prefix (#56). |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syncRepo now returns a tuple of new images and manifests instead of old repo information.