Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deployed_version): version from response headers and manual type #540

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

JosephKav
Copy link
Collaborator

@JosephKav JosephKav commented Mar 3, 2025

  1. Support for using a header of the response as the version (feat: Support for Header response searching #453)
services:
  argus:
    deployed_version:
      type: url
      target_header: 'X-Header-Name'

regex will apply to the header's value
image


  1. Support for a manual deployed_version type (feat: Manual Type Deployment version #454)
services:
  argus:
    deployed_version:
      type: manual
      version: 1.2.3

version is read and cleared on startup. If empty, the deployed_version from the DB is used. This manual version can also be updated from the web UI.

image
  1. Only send deployed_version.type when you have other fields (e.g. url/version). Fixes bug: all service saves send deployed_version.type: url, preventing saving of services with no deployed_version lookup #539 (introduced in 3d74a4c)

@JosephKav JosephKav added bug Something isn't working enhancement New feature or request javascript Pull requests that update Javascript code go Pull requests that update Go code labels Mar 3, 2025
@JosephKav JosephKav force-pushed the feat/deployed-version_version-from-response-header branch from 31c48de to faa3df6 Compare March 3, 2025 01:06
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (d7c2e8b) to head (e64907a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #540      +/-   ##
==========================================
+ Coverage   98.70%   98.71%   +0.02%     
==========================================
  Files         124      128       +4     
  Lines       10543    10661     +118     
==========================================
+ Hits        10405    10523     +118     
  Misses        112      112              
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JosephKav JosephKav force-pushed the feat/deployed-version_version-from-response-header branch from faa3df6 to 1d2e839 Compare March 3, 2025 11:42
@JosephKav JosephKav force-pushed the feat/deployed-version_version-from-response-header branch from 1d2e839 to af28196 Compare March 3, 2025 11:43
- bump @tanstack/react-query from 5.66.0 to 5.67.1
- bump @tanstack/react-query-devtools from 5.66.0 to 5.67.1
- bump @types/node from 22.13.1 to 22.13.8
- bump @types/react from 19.0.8 to 19.0.10
- bump @types/react-dom from 19.0.3 to 19.0.4
- bump react-router-dom from 7.1.5 to 7.2.0
- bump react-select from 5.10.0 to 5.10.1
- bump typescript from 5.7.3 to 5.8.2
- bump vite from 6.1.0 to 6.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request go Pull requests that update Go code javascript Pull requests that update Javascript code
Projects
None yet
1 participant