fix(service): use Connection header on HTTP requests

service/deployed_version/deployed_version.go

@@ -176,6 +176,7 @@ func (l *Lookup) httpRequest(logFrom utils.LogFrom) (rawBody []byte, err error)
 	}
 
 	// Set headers
+	req.Header.Set("Connection", "close")
 	for _, header := range l.Headers {
 		req.Header.Set(header.Key, header.Value)
 	}
@@ -190,7 +191,7 @@ func (l *Lookup) httpRequest(logFrom utils.LogFrom) (rawBody []byte, err error)
 	if err != nil {
 		// Don't crash on invalid certs.
 		if strings.Contains(err.Error(), "x509") {
-			err = fmt.Errorf("x509 (Cert invalid)")
+			err = fmt.Errorf("x509 (certificate invalid)")
 			jLog.Warn(err, logFrom, true)
 			return
 		}

service/latest_version/filters/docker.go

@@ -75,15 +75,17 @@ func (r *Require) DockerTagCheck(
 			req.Header.Set("Authorization", "Bearer "+token)
 		}
 	}
+	req.Header.Set("Connection", "close")
 	// Do the request
 	client := &http.Client{}
 	resp, err := client.Do(req)
 	if err != nil {
 		return fmt.Errorf("%s:%s - %s",
 			r.Docker.Image, tag, err)
 	}
-	defer resp.Body.Close()
+
 	// Parse the body
+	defer resp.Body.Close()
 	body, _ := io.ReadAll(resp.Body)
 	if resp.StatusCode != http.StatusOK {
 		return fmt.Errorf("%s:%s - %s",
@@ -215,6 +217,7 @@ func (d *DockerCheck) refreshDockerHubToken() (err error) {
 	if err != nil {
 		return err
 	}
+	req.Header.Set("Connection", "close")
 	req.Header.Add("Content-Type", "application/x-www-form-urlencoded")
 	// Do the request
 	client := &http.Client{}
@@ -223,8 +226,9 @@ func (d *DockerCheck) refreshDockerHubToken() (err error) {
 		jLog.Error(err, utils.LogFrom{Primary: "docker-hub", Secondary: d.Image}, true)
 		return
 	}
-	defer resp.Body.Close()
+
 	// Parse the body
+	defer resp.Body.Close()
 	body, _ := io.ReadAll(resp.Body)
 	if resp.StatusCode != http.StatusOK {
 		return fmt.Errorf(string(body))

service/latest_version/query.go

@@ -126,13 +126,14 @@ func (l *Lookup) httpRequest(logFrom utils.LogFrom) (rawBody []byte, err error)
 		return
 	}
 
+	// Set headers
+	req.Header.Set("Connection", "close")
 	if l.Type == "github" && utils.DefaultIfNil(l.GetAccessToken()) != "" {
 		req.Header.Set("Authorization", fmt.Sprintf("token %s", *l.GetAccessToken()))
 	}
 
 	client := &http.Client{Transport: customTransport}
 	resp, err := client.Do(req)
-
 	if err != nil {
 		// Don't crash on invalid certs.
 		if strings.Contains(err.Error(), "x509") {

web/api/v1/http.go

@@ -33,6 +33,7 @@ import (
 func (api *API) basicAuth() mux.MiddlewareFunc {
 	return func(h http.Handler) http.Handler {
 		return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+			defer r.Body.Close()
 			username, password, ok := r.BasicAuth()
 			if ok {
 				// Hash purely to prevent ConstantTimeCompare leaking lengths
@@ -51,6 +52,7 @@ func (api *API) basicAuth() mux.MiddlewareFunc {
 				}
 			}
 
+			w.Header().Set("Connection", "close")
 			w.Header().Set("WWW-Authenticate", `Basic realm="restricted", charset="UTF-8"`)
 			http.Error(w, "Unauthorized", http.StatusUnauthorized)
 		})
@@ -59,9 +61,7 @@ func (api *API) basicAuth() mux.MiddlewareFunc {
 
 // SetupRoutesAPI will setup the HTTP API routes.
 func (api *API) SetupRoutesAPI() {
-	api.Router.HandleFunc("/api/v1/version", func(w http.ResponseWriter, r *http.Request) {
-		api.httpVersion(w, r)
-	})
+	api.Router.HandleFunc("/api/v1/version", api.httpVersion)
 }
 
 // SetupRoutesNodeJS will setup the HTTP routes to the NodeJS files.
@@ -85,6 +85,8 @@ func (api *API) SetupRoutesNodeJS() {
 func (api *API) httpVersion(w http.ResponseWriter, r *http.Request) {
 	logFrom := utils.LogFrom{Primary: "apiVersion"}
 	api.Log.Verbose("-", logFrom, true)
+	w.Header().Set("Connection", "close")
+	w.Header().Set("Content-Type", "application/json")
 	err := json.NewEncoder(w).Encode(api_types.VersionAPI{
 		Version:   utils.Version,
 		BuildDate: utils.BuildDate,

web/web.go

@@ -39,6 +39,8 @@ func NewRouter(cfg *config.Config, jLog *utils.JLog, hub *api_v1.Hub) *mux.Route
 
 	// WebSocket
 	api.Router.HandleFunc("/ws", func(w http.ResponseWriter, r *http.Request) {
+		w.Header().Set("Connection", "close")
+		defer r.Body.Close()
 		api_v1.ServeWs(api, hub, w, r)
 	})
 

webhook/init.go

@@ -165,6 +165,7 @@ func (w *WebHook) GetRequest() (req *http.Request) {
 
 		SetGitLabParameter(req, w.GetSecret())
 	}
+	req.Header.Set("Connection", "close")
 	w.SetCustomHeaders(req)
 	return
 }