feat: can skip releases for a deployed_service that has no webhooks

[samcro1967]

I noticed that the webhook buttons do not disappear after a webhook is removed from config.xml. They persist in the UI, but are disabled.

[JosephKav]

That's just how I designed it. I believe the info button looked too different otherwise and I wanted it to be a consistent layout/design

[jrhbcn]

@JosephKav Would it be possible to skip a release even if a webhook is not defined (but a deployment version is)? Sometimes I just want to skip a release without updating (for instance the .0 home assistant releases or the Unifi release candidates).

[JosephKav]

Yeah, I can look into adding this. Just not sure on how I'd discretely signify services that have skipped a version. I do this for those with webhooks by changing the resend icon to a tick

[samcro1967]

I would suggest adding "(skipped)" in the description after what is currently called To and remove the webhook buttons. Might also consider renaming "From" and "To" to current and deployed for consistency, although I think it is intuitive enough as is.

[jrhbcn]

Yes, something like @samcro1967 is suggesting sounds fine! I was thinking something similar as to keeping the info and removing the current greyed out "OK" and "cancel" buttons for a "skip" one (or even adding a "refresh" one to maintain the 3 button layout if you want).

[JosephKav]

I don't really want to keep those update available options when you skip a release as I want a skip to not loudly show that there is a new version available. Currently, when you skip a release with webhooks, those buttons disappear and the only indicator of the skip is the icon on the resend button becoming a tick. We can't do that as there's nothing to resend in these cases.

I've managed to get it to hide the 'Send' button, but still take up the same space. So here's the options you'll get if there's a deployed_version checker, but no webhooks:

I'm proposing we add another info icon to display that it's skipped, but just right-align it

Not sure whether to display that icon if there are webhooks

as the resend icon has changed, and the modal that pops up tells you which version it's on and would go to (so what version has been skipped)

I'm leaning towards keeping the existing layout when the service has webhooks and so only displaying this 'Skipped VERSION' icon when there are no webhooks

[samcro1967]

I think that makes sense. So you would click on the info button and get the ability to deploy if a webhook is present? And you can also skip a version if a webhook is not even present and get the info button?

[JosephKav]

So you would click on the info button and get the ability to deploy if a webhook is present?

nothing's changed if you have webhook.s You'll get the options to view info on it, approve it, and skip it

And you can also skip a version if a webhook is not even present and get the info button?

If you don't have any webhooks (but do have a deployed version it's checking as otherwise the version would update straight away), it'll give you my first picture with the info and skip buttons

[samcro1967]

Ah, now I understand. With no webhook defined, you go straight to skipped. So the only indication that you are a version behind at that point is the skipped button. I think that makes sense. Maybe make the button red so it jumps out.

[jrhbcn]

@JosephKav your proposal looks perfect! I would prefer having the skipped icon (maybe with an "s" instead of "i") always (even with webhooks defined) but it is just a small thing.

Thank you for considering this.

[JosephKav]

I do like the look of the S as two of the same icon looks a bit random. Coloured it yellow as a warning that an update's been skipped

Now I'm not too sure about how to handle the update being skipped and webhooks being available

• no change (tick icon when it's been skipped)
  
• yellow the tick icon
  
• show the S next to the webhook resend
  
  I'm slowly coming to prefering this over the yellow tick. What are your thoughts?
  

[jrhbcn]

I buy the "S" icon myself :)

[JosephKav]

Spent a while discussing possible designs with friends and eventually settled on this. The satellite symbol is what the (i) is currently (signifier of whether it's monitoring a deployed version of the service), and this new (i) is the version skipped one (Skipped 3.2.1). Also changed the resend icon to a rotate-right icon to look like retry/redo. Did have this a while ago but was a bit against it as people might think it's a refresh for the version query, but I'd say it bringing up a modal with options for resending webhooks overcomes that issue

Hope you like it!

(Am gonna rename this issue to better highlight what it's turned into + make the upcoming PR cleaner)

[JosephKav]

I've merged this feature to master now. Will do a release after adding send/resend for commands to the UI

[jrhbcn]

Hi @JosephKav

Congrats for the new release! :)

I just installed it, but I still see no way to skip a release. For example "Home Assistant" I still see:

With the "skip/cross" option greyed out :?

[JosephKav]

I just installed it, but I still see no way to skip a release. For example "Home Assistant" I still see:
With the "skip/cross" option greyed out :?

@jrhbcn, sorry about that! I've just fixed this in my latest commit (6972734). Turns out I had it marking every version as approved if there was a deployed_version lookup. We only want this approved_version to track skipping a release and when we've got a deployed_version lookup along with commands/webhooks that should perform the upgrade. So when we approve the release (send the webhooks/commands), it'd mark it as approved to stop you/someone else retriggering the upgrade that should already be in progress.

So I've updated it to fix this. All you should have to do on your end if you want to skip this latest release, would be to remove the approved_version line from your config. Or you can just ignore it and wait for a newer release and skip that one.

0.5.1 is building now

[jrhbcn]

Thanks yet again, working perfect now!