-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automatic fallback to tags for GitHub #275
Comments
Doing queries now on https://api.github.com/repos/go-vikunja/frontend/releases, https://api.github.com/repos/go-vikunja/frontend/releases and https://api.github.com/repos/allinurl/goaccess/releases gives me the I'm thinking that the ETag for empty releases isn't constant, so just do the first query with no ETag, and if that query on |
Trying again with Firefox I get the same ETag I had last week ( |
Ah, good that it's not changed in a week. |
some repositories use tags and not releases. switch a service to the tags api if /releases gives [] closes #275
some repositories use tags and not releases. switch a service to the tags api if /releases gives [] closes #275
some repositories use tags and not releases. switch a service to the tags api if /releases gives [] closes #275
some repositories use tags and not releases. switch a service to the tags api if /releases gives [] closes #275
some repositories use tags and not releases. switch a service to the tags api if /releases gives [] closes #275
some repositories use tags and not releases. switch a service to the tags api if /releases gives [] closes #275
some repositories use tags and not releases. switch a service to the tags api if /releases gives [] closes #275
some repositories use tags and not releases. switch a service to the tags api if /releases gives [] closes #275
Features * service: add /tags fallback to GitHub services (207e610), closes #275 * service: default service notify/command/webhook (08eb05f) * service: support leading "v" in versions (e.g. v1.2.3) (bdab68d) * web: lv url-commands, add regex index field (#274) (7def08c) Bug Fixes * db: switch to text for versions to keep trailing 0's (7289ce9) * notify: missing defaults for shoutrrr type (4bdbf17) * web: allow skip when command/webhook blocked by delay (4436d38) * web: compare previous semantic_version state in version refreshes (3414a24), closes #279 master
Features * service: add /tags fallback to GitHub services (207e610), closes #275 * service: default service notify/command/webhook (08eb05f) * service: support leading "v" in versions (e.g. v1.2.3) (bdab68d) * web: lv url-commands, add regex index field (#274) (7def08c) Bug Fixes * db: switch to text for versions to keep trailing 0's (7289ce9) * notify: missing defaults for shoutrrr type (4bdbf17) * web: allow skip when command/webhook blocked by delay (4436d38) * web: compare previous semantic_version state in version refreshes (3414a24), closes #279
Amazing, thanks! I'll update and test later today :) |
Works great, thanks! |
Is your feature request related to a problem? Please describe.
Having to manually specify
url_commands
for GitHub repos that use tags, but not releases is slightly inconvenient.Describe the solution you'd like
It would be nice if Argus could automatically fall back to tags if no releases exist for the service.
To do this without counting towards the API rate limit, the ETag could default to
"1202860668f8cc09802a90038fa4ff8cdc642644697a3ef85aace4bd6ed91973"
which is what GitHub returns for an empty list.In case of
304 Not Modified
, Argus should query the tags API and match the default regex against eachref
stripped from therefs/tags/
prefix.Here's an example tags API response:
I believe this would make almost any GitHub project work out of the box.
Describe alternatives you've considered
Manually specifying the
url_commands
for each such service works.The text was updated successfully, but these errors were encountered: