Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service): use Connection header on HTTP requests #156

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

JosephKav
Copy link
Collaborator

A significant difference between HTTP/1.1 and earlier versions of HTTP is that persistent connections are the default behavior of any HTTP connection.

Inform the server that the client wants to close the connection after the transaction is complete. This can be done by setting the Connection header
source

fix?

@JosephKav JosephKav added the bug Something isn't working label Sep 15, 2022
@JosephKav JosephKav force-pushed the close-http-connections branch from 453aa3b to 23f7f76 Compare September 15, 2022 09:43
@JosephKav JosephKav force-pushed the close-http-connections branch from 23f7f76 to 3ed5669 Compare September 15, 2022 10:05
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #156 (3ed5669) into master (6c8e559) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   97.64%   97.64%   +0.01%     
==========================================
  Files          63       63              
  Lines        5241     5248       +7     
==========================================
+ Hits         5117     5124       +7     
  Misses         89       89              
  Partials       35       35              
Impacted Files Coverage Δ
service/deployed_version/deployed_version.go 100.00% <100.00%> (ø)
service/latest_version/filters/docker.go 92.31% <100.00%> (+0.04%) ⬆️
service/latest_version/query.go 98.14% <100.00%> (ø)
web/api/v1/http.go 100.00% <100.00%> (ø)
web/web.go 92.50% <100.00%> (+0.40%) ⬆️
webhook/init.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JosephKav JosephKav merged commit 6f46976 into master Sep 15, 2022
@JosephKav JosephKav deleted the close-http-connections branch September 15, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant